Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2798943002: Change 'recipient' to 'name' in web payments UI. (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change 'recipient' to 'name' in web payments UI. 'Recipient' is confusing terminology. Use 'name' instead. As seen in 'Recipient required' error message and 'Add recipient' dialog title. BUG=708568 Review-Url: https://codereview.chromium.org/2798943002 Cr-Commit-Position: refs/heads/master@{#462073} Committed: https://chromium.googlesource.com/chromium/src/+/b5bc2c25b8e7e3ac3caf081c6d4acd7bd1af2142

Patch Set 1 #

Patch Set 2 : Grammar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/payments_strings.grdp View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
please use gerrit instead
Mathieu, ptal.
3 years, 8 months ago (2017-04-05 14:42:04 UTC) #3
Mathieu
lgtm
3 years, 8 months ago (2017-04-05 15:02:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798943002/20001
3 years, 8 months ago (2017-04-05 15:03:42 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 15:13:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b5bc2c25b8e7e3ac3caf081c6d4a...

Powered by Google App Engine
This is Rietveld 408576698