Restore mappings for older Xbox One S Bluetooth gamepads on OSX/Linux

Restore mappings for older Xbox One S Bluetooth gamepads on OSX/Linux

Microsoft released a firmware update for Xbox One S gamepads that changed
the button and axis assignments when connected over Bluetooth, requiring a
new mapping in Chrome. In a previous CL, the mappings for the old firmware
were removed under the assumption that soon all gamepads would use the new
firmware mappings. However, this was incorrect as the new mappings are not
exposed on all platforms. Furthermore, Xbox One S gamepads are still
shipping with the old FW and users may not have the means to update.

On OSX, gamepads with the old FW use device ID 045e:02e0 while those with
the new FW use 045e:02fd. This CL re-adds the mapping for the old FW that
was previously replaced. The new mapping will still be applied to gamepads
with the new FW.

On Linux, gamepads with either FW use device ID 045e:02e0 and need the old
mapping which was previously replaced. This CL re-adds the mapping for the
old FW. The new FW mapping is retained for now, but may be removed in the
future as it should now be unused.

On Windows, Xbox One S gamepads are handled by the OS and are exposed to
Chrome as Xbox 360 compatible gamepads. No extra work is required to
support the old FW.

On Android, the default mapping is correct for the new FW but a custom
mapping is required to support the old FW. This will be addressed in a
future CL.

BUG=705506
Review-Url: https://codereview.chromium.org/2798933004
Cr-Commit-Position: refs/heads/master@{#490505}
Committed: https://chromium.googlesource.com/chromium/src/+/0901a39d9de30d0a98d483a79b7963cbcf1cfd90

[mattreynolds, 2017-07-28 01:41:01]

Description was changed from

==========
Restore mappings for older Xbox One S Bluetooth gamepads

At some point Microsoft started using the device ID 045e 02fd for the
Bluetooth interface on Xbox One S gamepads. In a previous CL, the mappings
for Mac and Linux were updated with the new product ID, which broke
compatibility for gamepads still using the old ID. This CL restores the
old mappings while keeping the new ones.

BUG=705506
==========

to

==========
Restore mappings for older Xbox One S Bluetooth gamepads on OSX/Linux

Microsoft released a firmware update for Xbox One S gamepads that changed
the button and axis assignments when connected over Bluetooth, requiring a
new mapping in Chrome. In a previous CL, the mappings for the old firmware
were removed under the assumption that soon all gamepads would use the new
firmware mappings. However, this was incorrect as the new mappings are not
exposed on all platforms. Furthermore, Xbox One S gamepads are still
shipping with the old FW and users may not have the means to update.

On OSX, gamepads with the old FW use device ID 045e:02e0 while those with
the new FW use 045e:02fd. This CL re-adds the mapping for the old FW that
was previously replaced. The new mapping will still be applied to gamepads
with the new FW.

On Linux, gamepads with either FW use device ID 045e:02e0 and need the old
mapping which was previously replaced. This CL re-adds the mapping for the
old FW. The new FW mapping is retained for now, but may be removed in the
future as it should now be unused.

On Windows, Xbox One S gamepads are handled by the OS and are exposed to
Chrome as Xbox 360 compatible gamepads. No extra work is required to
support the old FW.

On Android, the default mapping is correct for the new FW but a custom
mapping is required to support the old FW. This will be addressed in a
future CL.

BUG=705506
==========

[mattreynolds, 2017-07-28 01:41:02]

mattreynolds@chromium.org changed reviewers:
+ bajones@chromium.org

[mattreynolds, 2017-07-28 01:42:12]

Hi Brandon, PTAL. This fixes Xbox One S gamepads on Linux and re-enables the
mapping for the old firmware on OSX.

[bajones, 2017-07-28 19:19:03]

On 2017/07/28 01:42:12, mattreynolds wrote:
> Hi Brandon, PTAL. This fixes Xbox One S gamepads on Linux and re-enables the
> mapping for the old firmware on OSX.

LGTM, thanks!

[mattreynolds, 2017-07-28 19:31:44]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2017-07-28 19:32:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-28 20:55:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501270304623370,
"parent_rev": "028616d2593c59a14a87b218b4ef716ae77e1e69", "commit_rev":
"0901a39d9de30d0a98d483a79b7963cbcf1cfd90"}

[commit-bot: I haz the power, 2017-07-28 20:56:09]

Description was changed from

==========
Restore mappings for older Xbox One S Bluetooth gamepads on OSX/Linux

Microsoft released a firmware update for Xbox One S gamepads that changed
the button and axis assignments when connected over Bluetooth, requiring a
new mapping in Chrome. In a previous CL, the mappings for the old firmware
were removed under the assumption that soon all gamepads would use the new
firmware mappings. However, this was incorrect as the new mappings are not
exposed on all platforms. Furthermore, Xbox One S gamepads are still
shipping with the old FW and users may not have the means to update.

On OSX, gamepads with the old FW use device ID 045e:02e0 while those with
the new FW use 045e:02fd. This CL re-adds the mapping for the old FW that
was previously replaced. The new mapping will still be applied to gamepads
with the new FW.

On Linux, gamepads with either FW use device ID 045e:02e0 and need the old
mapping which was previously replaced. This CL re-adds the mapping for the
old FW. The new FW mapping is retained for now, but may be removed in the
future as it should now be unused.

On Windows, Xbox One S gamepads are handled by the OS and are exposed to
Chrome as Xbox 360 compatible gamepads. No extra work is required to
support the old FW.

On Android, the default mapping is correct for the new FW but a custom
mapping is required to support the old FW. This will be addressed in a
future CL.

BUG=705506
==========

to

==========
Restore mappings for older Xbox One S Bluetooth gamepads on OSX/Linux

Microsoft released a firmware update for Xbox One S gamepads that changed
the button and axis assignments when connected over Bluetooth, requiring a
new mapping in Chrome. In a previous CL, the mappings for the old firmware
were removed under the assumption that soon all gamepads would use the new
firmware mappings. However, this was incorrect as the new mappings are not
exposed on all platforms. Furthermore, Xbox One S gamepads are still
shipping with the old FW and users may not have the means to update.

On OSX, gamepads with the old FW use device ID 045e:02e0 while those with
the new FW use 045e:02fd. This CL re-adds the mapping for the old FW that
was previously replaced. The new mapping will still be applied to gamepads
with the new FW.

On Linux, gamepads with either FW use device ID 045e:02e0 and need the old
mapping which was previously replaced. This CL re-adds the mapping for the
old FW. The new FW mapping is retained for now, but may be removed in the
future as it should now be unused.

On Windows, Xbox One S gamepads are handled by the OS and are exposed to
Chrome as Xbox 360 compatible gamepads. No extra work is required to
support the old FW.

On Android, the default mapping is correct for the new FW but a custom
mapping is required to support the old FW. This will be addressed in a
future CL.

BUG=705506

Review-Url: https://codereview.chromium.org/2798933004
Cr-Commit-Position: refs/heads/master@{#490505}
Committed:
https://chromium.googlesource.com/chromium/src/+/0901a39d9de30d0a98d483a79b79...
==========

[commit-bot: I haz the power, 2017-07-28 20:56:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0901a39d9de30d0a98d483a79b79...