Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2798923004: Call PersistentHandleVisitor directly instead of using ObjectVisitor. (Closed)

Created:
3 years, 8 months ago by ulan
Modified:
3 years, 8 months ago
Reviewers:
Michael Lippautz, alph
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, jochen (gone - plz use gerrit)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Call PersistentHandleVisitor directly instead of using ObjectVisitor. This removes one virtual function from ObjectVisitor. BUG=chromium:709075 Review-Url: https://codereview.chromium.org/2798923004 Cr-Commit-Position: refs/heads/master@{#44476} Committed: https://chromium.googlesource.com/v8/v8/+/4a87608d7f2fe6414146ddf22de2a84099cd3f39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -55 lines) Patch
M src/api.cc View 2 chunks +3 lines, -27 lines 0 comments Download
M src/global-handles.h View 3 chunks +12 lines, -11 lines 0 comments Download
M src/global-handles.cc View 1 chunk +18 lines, -8 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ulan
ptal
3 years, 8 months ago (2017-04-06 16:11:30 UTC) #2
ulan
Adding alph@ for src/profiler change.
3 years, 8 months ago (2017-04-06 16:12:27 UTC) #4
Michael Lippautz
lgtm from my side
3 years, 8 months ago (2017-04-06 16:16:10 UTC) #5
ulan
+Jochen: fyi.
3 years, 8 months ago (2017-04-06 16:16:21 UTC) #6
alph
lgtm
3 years, 8 months ago (2017-04-06 20:53:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798923004/1
3 years, 8 months ago (2017-04-07 07:58:38 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 09:17:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4a87608d7f2fe6414146ddf22de2a84099c...

Powered by Google App Engine
This is Rietveld 408576698