Return computed style for width/height for non-root SVG

Return 'auto' for width/height for non-root SVG

According to the specs:
- https://www.w3.org/TR/CSS2/visudet.html#the-height-property:
  The 'height' property doesn't apply to non-atomic inline elements.
- https://drafts.csswg.org/cssom/#resolved-value:
  getComputeStyle() returns resolved values. For a property that
  doesn't apply, the resolved value is the computed value.

Actually because of crbug.com/708888 'auto' is not the computed value
when width/height is specified, but this keeps the current behavior.

I didn't find spec about whether a non-root SVG is inline or not,
but SVG's display's initial value is 'inline', and we treat most of
the SVG elements always as inline. We treat SVG text as block internally
just because we implement SVG text based on LayoutBlockFlow, which is
an implementation detail and should not affect cssom.

BUG=708687
Review-Url: https://codereview.chromium.org/2798903005
Cr-Commit-Position: refs/heads/master@{#462508}
Committed: https://chromium.googlesource.com/chromium/src/+/e60f30d448ad169ebc5c7f1cf45e83da2af33959

[Xianzhu, 2017-04-05 21:25:02]

wangxianzhu@chromium.org changed reviewers:
+ fs@opera.com

[fs, 2017-04-05 21:36:38]

lgtm

https://codereview.chromium.org/2798903005/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/css/getComputedStyle-svg-text-width-height.html
(right):

https://codereview.chromium.org/2798903005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/css/getComputedStyle-svg-text-width-height.html:14:
});
Add a <title> or an explicit test name (or there'll an default name, which isn't
great.)

[Xianzhu, 2017-04-05 21:48:25]

https://codereview.chromium.org/2798903005/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/css/getComputedStyle-svg-text-width-height.html
(right):

https://codereview.chromium.org/2798903005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/css/getComputedStyle-svg-text-width-height.html:14:
});
On 2017/04/05 21:36:38, fs wrote:
> Add a <title> or an explicit test name (or there'll an default name, which
isn't
> great.)

Done.

[Xianzhu, 2017-04-05 21:48:51]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-04-05 21:48:51]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2798903005/#ps60001
(title: "-")

[commit-bot: I haz the power, 2017-04-05 21:49:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:05:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:05:32]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2017-04-06 05:19:10]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-04-06 05:19:11]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2798903005/#ps70001
(title: "Reduce behavior change")

[commit-bot: I haz the power, 2017-04-06 05:19:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-04-06 05:21:04]

Description was changed from

==========
Return computed style for width/height for non-root SVG

According to the specs:
- https://www.w3.org/TR/CSS2/visudet.html#the-height-property:
  The 'height' property doesn't apply to non-atomic inline elements.
- https://www.w3.org/TR/CSS2/cascade.html#computed-value:
  The computed value exists even when the property doesn't apply.
- https://drafts.csswg.org/cssom/#resolved-value:
  getComputeStyle() returns resolved values. For a property that
  doesn't apply, the resolved value is the computed value.

I didn't find spec about whether a non-root SVG is inline or not,
but SVG's display's initial value is 'inline', and we treat most of
the SVG elements always as inline. We treat SVG text as block internally
just because we implement SVG text based on LayoutBlockFlow, which is
an implementation detail and should not affect cssom.

BUG=708687
==========

to

==========
Return 'auto' for width/height for non-root SVG

According to the specs:
- https://www.w3.org/TR/CSS2/visudet.html#the-height-property:
  The 'height' property doesn't apply to non-atomic inline elements.
- https://drafts.csswg.org/cssom/#resolved-value:
  getComputeStyle() returns resolved values. For a property that
  doesn't apply, the resolved value is the computed value.

Actually because of crbug.com/708888 'auto' is not the computed value
when width/height is specified, but this keeps the current behavior.

I didn't find spec about whether a non-root SVG is inline or not,
but SVG's display's initial value is 'inline', and we treat most of
the SVG elements always as inline. We treat SVG text as block internally
just because we implement SVG text based on LayoutBlockFlow, which is
an implementation detail and should not affect cssom.

BUG=708687
==========

[commit-bot: I haz the power, 2017-04-06 07:31:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 07:31:30]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-04-06 15:10:49]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-04-06 15:11:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 16:46:47]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1491491449655220,
"parent_rev": "62a2ae30d462e81047c059c06f8ded35c9499fd8", "commit_rev":
"e60f30d448ad169ebc5c7f1cf45e83da2af33959"}

[commit-bot: I haz the power, 2017-04-06 16:47:36]

Description was changed from

==========
Return 'auto' for width/height for non-root SVG

According to the specs:
- https://www.w3.org/TR/CSS2/visudet.html#the-height-property:
  The 'height' property doesn't apply to non-atomic inline elements.
- https://drafts.csswg.org/cssom/#resolved-value:
  getComputeStyle() returns resolved values. For a property that
  doesn't apply, the resolved value is the computed value.

Actually because of crbug.com/708888 'auto' is not the computed value
when width/height is specified, but this keeps the current behavior.

I didn't find spec about whether a non-root SVG is inline or not,
but SVG's display's initial value is 'inline', and we treat most of
the SVG elements always as inline. We treat SVG text as block internally
just because we implement SVG text based on LayoutBlockFlow, which is
an implementation detail and should not affect cssom.

BUG=708687
==========

to

==========
Return 'auto' for width/height for non-root SVG

According to the specs:
- https://www.w3.org/TR/CSS2/visudet.html#the-height-property:
  The 'height' property doesn't apply to non-atomic inline elements.
- https://drafts.csswg.org/cssom/#resolved-value:
  getComputeStyle() returns resolved values. For a property that
  doesn't apply, the resolved value is the computed value.

Actually because of crbug.com/708888 'auto' is not the computed value
when width/height is specified, but this keeps the current behavior.

I didn't find spec about whether a non-root SVG is inline or not,
but SVG's display's initial value is 'inline', and we treat most of
the SVG elements always as inline. We treat SVG text as block internally
just because we implement SVG text based on LayoutBlockFlow, which is
an implementation detail and should not affect cssom.

BUG=708687

Review-Url: https://codereview.chromium.org/2798903005
Cr-Commit-Position: refs/heads/master@{#462508}
Committed:
https://chromium.googlesource.com/chromium/src/+/e60f30d448ad169ebc5c7f1cf45e...
==========

[commit-bot: I haz the power, 2017-04-06 16:47:37]

Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/e60f30d448ad169ebc5c7f1cf45e...