Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2798863003: Rewrite references to "wtf/" to "platform/wtf/" in platform/image-decoders. (Closed)

Created:
3 years, 8 months ago by Yuta Kitamura
Modified:
3 years, 8 months ago
Reviewers:
scroggo_chromium
CC:
chromium-reviews, blink-reviews, jzern, kinuko+watch, skal, urvang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite references to "wtf/" to "platform/wtf/" in platform/image-decoders. This is essentially the result of the following shell command followed by git cl format: find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \; DEPS is added in order to prevent further introduction of "wtf/". BUG=691465 Review-Url: https://codereview.chromium.org/2798863003 Cr-Commit-Position: refs/heads/master@{#462386} Committed: https://chromium.googlesource.com/chromium/src/+/2d8670f4d8227674e815e3fa63b624e8bdf2e6ef

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused RefPtr.h. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -67 lines) Patch
A third_party/WebKit/Source/platform/image-decoders/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/SegmentReader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/SegmentReader.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Yuta Kitamura
scroggo: PTAL? (For context, see my announcement in blink-dev.)
3 years, 8 months ago (2017-04-05 11:04:21 UTC) #7
scroggo_chromium
LGTM https://codereview.chromium.org/2798863003/diff/1/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h (right): https://codereview.chromium.org/2798863003/diff/1/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h#newcode33 third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h:33: #include "platform/wtf/RefPtr.h" nit: Can this be removed? (I ...
3 years, 8 months ago (2017-04-05 15:42:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798863003/20001
3 years, 8 months ago (2017-04-06 06:03:08 UTC) #11
Yuta Kitamura
https://codereview.chromium.org/2798863003/diff/1/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h (right): https://codereview.chromium.org/2798863003/diff/1/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h#newcode33 third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h:33: #include "platform/wtf/RefPtr.h" On 2017/04/05 15:42:46, scroggo_chromium wrote: > nit: ...
3 years, 8 months ago (2017-04-06 06:03:13 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 07:52:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2d8670f4d8227674e815e3fa63b6...

Powered by Google App Engine
This is Rietveld 408576698