Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2798863002: PagePopupController: handle frame-detached window usage. (Closed)

Created:
3 years, 8 months ago by sof
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PagePopupController: handle frame-detached window usage. R=haraken BUG=708225 Review-Url: https://codereview.chromium.org/2798863002 Cr-Commit-Position: refs/heads/master@{#462078} Committed: https://chromium.googlesource.com/chromium/src/+/8d3aa0bf80ed15648b30bae0621e15e6eef37d64

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/calendar-picker/week-picker-close-no-crash.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
sof
please take a look.
3 years, 8 months ago (2017-04-05 11:51:06 UTC) #9
haraken
LGTM
3 years, 8 months ago (2017-04-05 11:52:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798863002/20001
3 years, 8 months ago (2017-04-05 15:22:49 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 15:31:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8d3aa0bf80ed15648b30bae0621e...

Powered by Google App Engine
This is Rietveld 408576698