Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2798843004: [heap] Enable verification of evacuation for old space (Closed)

Created:
3 years, 8 months ago by Michael Lippautz
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Enable verification of evacuation for old space Was disabled in the case we use allocation folding, i.e., always... Sheriffs: This might flush out missed write barriers. In that case: Lets revert and investigate. BUG= Review-Url: https://codereview.chromium.org/2798843004 Cr-Commit-Position: refs/heads/master@{#44432} Committed: https://chromium.googlesource.com/v8/v8/+/b5b87aecf1a1a591d65cac5406dec787b6eb08e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Michael Lippautz
ptal
3 years, 8 months ago (2017-04-05 10:55:23 UTC) #6
Hannes Payer (out of office)
lgtm
3 years, 8 months ago (2017-04-06 08:07:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798843004/1
3 years, 8 months ago (2017-04-06 09:02:37 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 09:04:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b5b87aecf1a1a591d65cac5406dec787b6e...

Powered by Google App Engine
This is Rietveld 408576698