Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2798813002: Revert of Set user agent type of transient item the same as pending item. (Closed)

Created:
3 years, 8 months ago by liaoyuke
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org, huangml1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set user agent type of transient item the same as pending item. (patchset #9 id:280001 of https://codereview.chromium.org/2779263002/ ) Reason for revert: Revert because this CL is breaking downstream tests. Original issue's description: > Set user agent type of transient item the same as pending item. > > In current code, when deciding which user agent type to use for > pre-loading next item, the user agent of transient item is also taken > into consideration, and because the user agent type of transient item > is always MOBILE, this results in the following behavior: > > Goto www.facebook.com -> Request Desktop Site -> > Goto https://expired.badssl.com -> Goto www.amazon.com. > > Now, instead of visiting the desktop version of www.amazon.com, it's > visiting the mobile version. > > This CL fixes the issue by accurately set the user agent type of > transient item as the user agent type of corresponding pending item. > > BUG=706446 > > Review-Url: https://codereview.chromium.org/2779263002 > Cr-Commit-Position: refs/heads/master@{#461856} > Committed: https://chromium.googlesource.com/chromium/src/+/0c1d4036c5f4aafb0530816aafce288cc56a691b TBR=eugenebut@chromium.org,kkhorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706446 Review-Url: https://codereview.chromium.org/2798813002 Cr-Commit-Position: refs/heads/master@{#461986} Committed: https://chromium.googlesource.com/chromium/src/+/2b3e817a6ccd91bc68501777d88659d429ca50cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -72 lines) Patch
M ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/interstitials/web_interstitial_impl.mm View 2 chunks +7 lines, -3 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 chunk +0 lines, -9 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 chunk +0 lines, -38 lines 0 comments Download
M ios/web/public/test/web_test_with_web_state.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ios/web/public/test/web_test_with_web_state.mm View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
liaoyuke
Created Revert of Set user agent type of transient item the same as pending item.
3 years, 8 months ago (2017-04-05 05:24:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798813002/1
3 years, 8 months ago (2017-04-05 05:24:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2b3e817a6ccd91bc68501777d88659d429ca50cd
3 years, 8 months ago (2017-04-05 05:26:50 UTC) #7
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-05 15:27:27 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698