Revert of MD Settings: Google Play Store: Add subpage and polish

Revert of MD Settings: Google Play Store: Add subpage and polish (patchset #4 id:60001 of https://codereview.chromium.org/2785013003/ )

Reason for revert:
This change causes 88 browser_tests to fail on
Builder Linux ChromiumOS Tests (dbg)(1) Build 

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24459

Original issue's description:
> MD Settings: Google Play Store: Add subpage and polish
> 
> See issue for screenshots and details.
> 
> BUG=698463
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2785013003
> Cr-Commit-Position: refs/heads/master@{#461813}
> Committed: https://chromium.googlesource.com/chromium/src/+/936a64459466aea94d5782255bc0570d9d764dae

TBR=dbeam@chromium.org,stevenjb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698463
Review-Url: https://codereview.chromium.org/2798753002
Cr-Commit-Position: refs/heads/master@{#461864}
Committed: https://chromium.googlesource.com/chromium/src/+/efc241285631bb8f93f709b8cf35c3eee7511ad5

[kelvinp, 2017-04-04 22:11:56]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2017-04-04 22:11:56]

Created Revert of MD Settings: Google Play Store: Add subpage and polish

[commit-bot: I haz the power, 2017-04-04 22:12:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 22:13:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491343916214290, "parent_rev":
"f7d92cff18cba731d3a33d19d3f9595bbacd6fb6", "commit_rev":
"efc241285631bb8f93f709b8cf35c3eee7511ad5"}

[commit-bot: I haz the power, 2017-04-04 22:14:32]

Description was changed from

==========
Revert of MD Settings: Google Play Store: Add subpage and polish (patchset #4
id:60001 of https://codereview.chromium.org/2785013003/ )

Reason for revert:
This change causes 88 browser_tests to fail on
Builder Linux ChromiumOS Tests (dbg)(1) Build 

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

Original issue's description:
> MD Settings: Google Play Store: Add subpage and polish
> 
> See issue for screenshots and details.
> 
> BUG=698463
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2785013003
> Cr-Commit-Position: refs/heads/master@{#461813}
> Committed:
https://chromium.googlesource.com/chromium/src/+/936a64459466aea94d5782255bc0...

TBR=dbeam@chromium.org,stevenjb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698463
==========

to

==========
Revert of MD Settings: Google Play Store: Add subpage and polish (patchset #4
id:60001 of https://codereview.chromium.org/2785013003/ )

Reason for revert:
This change causes 88 browser_tests to fail on
Builder Linux ChromiumOS Tests (dbg)(1) Build 

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

Original issue's description:
> MD Settings: Google Play Store: Add subpage and polish
> 
> See issue for screenshots and details.
> 
> BUG=698463
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2785013003
> Cr-Commit-Position: refs/heads/master@{#461813}
> Committed:
https://chromium.googlesource.com/chromium/src/+/936a64459466aea94d5782255bc0...

TBR=dbeam@chromium.org,stevenjb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698463

Review-Url: https://codereview.chromium.org/2798753002
Cr-Commit-Position: refs/heads/master@{#461864}
Committed:
https://chromium.googlesource.com/chromium/src/+/efc241285631bb8f93f709b8cf35...
==========

[commit-bot: I haz the power, 2017-04-04 22:14:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/efc241285631bb8f93f709b8cf35...

[Dan Beam, 2017-04-04 22:17:50]

fwiw: whoever's writing these tests that look for rendered text to verify ARC++
is on should freakin' stop it.

[kelvinp, 2017-04-04 22:21:39]

Description was changed from

==========
Revert of MD Settings: Google Play Store: Add subpage and polish (patchset #4
id:60001 of https://codereview.chromium.org/2785013003/ )

Reason for revert:
This change causes 88 browser_tests to fail on
Builder Linux ChromiumOS Tests (dbg)(1) Build 

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

Original issue's description:
> MD Settings: Google Play Store: Add subpage and polish
> 
> See issue for screenshots and details.
> 
> BUG=698463
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2785013003
> Cr-Commit-Position: refs/heads/master@{#461813}
> Committed:
https://chromium.googlesource.com/chromium/src/+/936a64459466aea94d5782255bc0...

TBR=dbeam@chromium.org,stevenjb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698463

Review-Url: https://codereview.chromium.org/2798753002
Cr-Commit-Position: refs/heads/master@{#461864}
Committed:
https://chromium.googlesource.com/chromium/src/+/efc241285631bb8f93f709b8cf35...
==========

to

==========
Revert of MD Settings: Google Play Store: Add subpage and polish (patchset #4
id:60001 of https://codereview.chromium.org/2785013003/ )

Reason for revert:
This change causes 88 browser_tests to fail on
Builder Linux ChromiumOS Tests (dbg)(1) Build 

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

Original issue's description:
> MD Settings: Google Play Store: Add subpage and polish
> 
> See issue for screenshots and details.
> 
> BUG=698463
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2785013003
> Cr-Commit-Position: refs/heads/master@{#461813}
> Committed:
https://chromium.googlesource.com/chromium/src/+/936a64459466aea94d5782255bc0...

TBR=dbeam@chromium.org,stevenjb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698463

Review-Url: https://codereview.chromium.org/2798753002
Cr-Commit-Position: refs/heads/master@{#461864}
Committed:
https://chromium.googlesource.com/chromium/src/+/efc241285631bb8f93f709b8cf35...
==========

[stevenjb, 2017-04-04 22:22:31]

Dan: This is unrelated, this was a failing browser test (and sloppiness on
my part):
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...


On Tue, Apr 4, 2017 at 3:17 PM, <dbeam@chromium.org> wrote:

> fwiw: whoever's writing these tests that look for rendered text to verify
> ARC++
> is on should freakin' stop it.
>
> https://codereview.chromium.org/2798753002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[kelvinp, 2017-04-04 22:22:55]

On 2017/04/04 22:17:50, Dan Beam wrote:
> fwiw: whoever's writing these tests that look for rendered text to verify
ARC++
> is on should freakin' stop it.

cc'ing the ChromeOS gardener - achuith@

[Dan Beam, 2017-04-04 22:27:19]

On 2017/04/04 22:22:31, stevenjb wrote:
> Dan: This is unrelated, this was a failing browser test (and sloppiness on
> my part):
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...

ah, thought it was related cuz

[16686:16686:0404/135948.212375:FATAL:l10n_util.cc(719)] Check failed:
std::string::npos != pos (18446744073709551615 vs. 18446744073709551615) Didn't
find a $1 placeholder in Apps you?ve downloaded from Google Play will be deleted
from this Chromebook.
      <br><br>
      Content you?ve purchased such as movies, TV shows, music, books, or other
in-app purchases may also be deleted.
      <br><br>
      This doesn?t affect apps or content on other devices.

guess not :(