Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2798743002: Migrate SQLiteChannelIDStore away from using deprecated ECPrivateKey functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by nharper
Modified:
6 months, 2 weeks ago
Reviewers:
davidben, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate SQLiteChannelIDStore away from using deprecated ECPrivateKey functions BUG=618026 Review-Url: https://codereview.chromium.org/2798743002 Cr-Commit-Position: refs/heads/master@{#461958} Committed: https://chromium.googlesource.com/chromium/src/+/9e5df82b734aaf9c6dc37646acf0791737b55c70

Patch Set 1 #

Total comments: 6

Patch Set 2 : respond to comments #

Patch Set 3 : rebase #

Messages

Total messages: 11 (5 generated)
nharper
6 months, 2 weeks ago (2017-04-04 22:05:26 UTC) #2
mattm
https://codereview.chromium.org/2798743002/diff/1/net/extras/sqlite/sqlite_channel_id_store.cc File net/extras/sqlite/sqlite_channel_id_store.cc (right): https://codereview.chromium.org/2798743002/diff/1/net/extras/sqlite/sqlite_channel_id_store.cc#newcode331 net/extras/sqlite/sqlite_channel_id_store.cc:331: } else if (cur_version >= 2 && cur_version <= ...
6 months, 2 weeks ago (2017-04-04 22:44:24 UTC) #3
nharper
https://codereview.chromium.org/2798743002/diff/1/net/extras/sqlite/sqlite_channel_id_store.cc File net/extras/sqlite/sqlite_channel_id_store.cc (right): https://codereview.chromium.org/2798743002/diff/1/net/extras/sqlite/sqlite_channel_id_store.cc#newcode331 net/extras/sqlite/sqlite_channel_id_store.cc:331: } else if (cur_version >= 2 && cur_version <= ...
6 months, 2 weeks ago (2017-04-04 23:01:31 UTC) #4
mattm
lgtm
6 months, 2 weeks ago (2017-04-04 23:27:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798743002/40001
6 months, 2 weeks ago (2017-04-05 00:01:53 UTC) #8
commit-bot: I haz the power
6 months, 2 weeks ago (2017-04-05 02:57:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e5df82b734aaf9c6dc37646acf0...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa