Issue 2798643002: Plugins: Add UKM Metrics to Flash loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2798643002: Plugins: Add UKM Metrics to Flash loads (Closed)

Created:
3 years, 8 months ago by tommycli

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Plugins: Add UKM Metrics to Flash loads Tracks the main frame's URL for loads of Flash plugin instances. BUG=704688 Review-Url: https://codereview.chromium.org/2768263003 Cr-Commit-Position: refs/heads/master@{#461458} (cherry picked from commit 910b408e9d1ba5c36b5663a682b70cfc43e58a53) Review-Url: https://codereview.chromium.org/2798643002 . Cr-Commit-Position: refs/branch-heads/3029@{#570} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/9e5d523917b41921ae89fa538492f8a0ca84566a

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -34 lines)			Patch
M	chrome/browser/plugins/plugin_info_message_filter.h	View	3 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/plugins/plugin_info_message_filter.cc	View	4 chunks	+59 lines, -32 lines	0 comments	Download
M	components/ukm/ukm_service.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

tommycli

3 years, 8 months ago (2017-04-04 17:30:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9e5d523917b41921ae89fa538492f8a0ca84566a (tree was closed).