Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2798603003: Implement parsing of metadata on local variables. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 2 chunks +7 lines, -0 lines 2 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 6 chunks +11 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahe
3 years, 8 months ago (2017-04-04 15:54:18 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2798603003/diff/1/pkg/analyzer/lib/src/fasta/ast_builder.dart File pkg/analyzer/lib/src/fasta/ast_builder.dart (right): https://codereview.chromium.org/2798603003/diff/1/pkg/analyzer/lib/src/fasta/ast_builder.dart#newcode1859 pkg/analyzer/lib/src/fasta/ast_builder.dart:1859: } Do we need this? Did you forget ...
3 years, 8 months ago (2017-04-04 15:57:30 UTC) #3
Johnni Winther
lgtm
3 years, 8 months ago (2017-04-05 09:21:52 UTC) #4
ahe
Thank you! https://codereview.chromium.org/2798603003/diff/1/pkg/analyzer/lib/src/fasta/ast_builder.dart File pkg/analyzer/lib/src/fasta/ast_builder.dart (right): https://codereview.chromium.org/2798603003/diff/1/pkg/analyzer/lib/src/fasta/ast_builder.dart#newcode1859 pkg/analyzer/lib/src/fasta/ast_builder.dart:1859: } On 2017/04/04 15:57:30, scheglov wrote: > ...
3 years, 8 months ago (2017-04-05 14:18:03 UTC) #5
ahe
3 years, 8 months ago (2017-04-05 17:12:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fcc4ee0247407082b2621ea5f904c90e5cf93ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698