Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2798603003: Implement parsing of metadata on local variables. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index eca84354e80810b6cb60aa1e488822d9accd27c4..c945a78bd1200a7b86eb6dd21fe383e00b516d15 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -957,7 +957,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
initializer: initializer,
type: currentLocalVariableType ?? const DynamicType(),
isFinal: isFinal,
- isConst: isConst)..fileEqualsOffset = equalsCharOffset);
+ isConst: isConst)
+ ..fileEqualsOffset = equalsCharOffset);
}
@override
@@ -1011,6 +1012,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
constantExpressionRequired = pop();
currentLocalVariableType = pop();
currentLocalVariableModifiers = pop();
+ pop(); // Metadata.
if (variables.length != 1) {
push(variables);
} else {
@@ -1413,7 +1415,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
type: type,
initializer: name.initializer,
isFinal: isFinal,
- isConst: isConst)..fileOffset = name.fileOffset;
+ isConst: isConst)
+ ..fileOffset = name.fileOffset;
} else {
addCompileTimeError(
name.fileOffset, "'${name.name}' isn't a field in this class.");
@@ -1423,7 +1426,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
type: type ?? const DynamicType(),
initializer: name.initializer,
isFinal: isFinal,
- isConst: isConst)..fileOffset = name.fileOffset;
+ isConst: isConst)
+ ..fileOffset = name.fileOffset;
push(variable);
}
@@ -2016,7 +2020,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
"Expected lvalue, but got ${lvalue}", forToken.next.next.charOffset));
}
Statement result = new ForInStatement(variable, expression, body,
- isAsync: awaitToken != null)..fileOffset = body.fileOffset;
+ isAsync: awaitToken != null)
+ ..fileOffset = body.fileOffset;
if (breakTarget.hasUsers) {
result = new LabeledStatement(result);
breakTarget.resolveBreaks(result);
@@ -2174,7 +2179,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
expressionOffsets.add(expression.fileOffset);
}
push(new SwitchCase(expressions, expressionOffsets, block,
- isDefault: defaultKeyword != null)..fileOffset = firstToken.charOffset);
+ isDefault: defaultKeyword != null)
+ ..fileOffset = firstToken.charOffset);
push(labels);
}

Powered by Google App Engine
This is Rietveld 408576698