Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2798523002: Revert of Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData (Closed)

Created:
3 years, 8 months ago by Timothy Loh
Modified:
3 years, 8 months ago
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, haraken, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData (patchset #10 id:180001 of https://codereview.chromium.org/2771813003/ ) Reason for revert: TestConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat crashing On WebKit Linux Trusty (dbg), has been flakily crashing (passing on retry) since it was added but now is crashing consistently. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29 Crashes more on the ClangToTLinuxASan/ClangToTMacASan fyi bots. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=TestConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat Original issue's description: > Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData > > * createImageData() and getImageData() must return an ImageData for which the color space and storage format matches those of canvas. > If canvas pixel format is "float16", the storage format of the returned ImageData must be "float32". Values must be properly converted from float16 to float32. > > * putImageData must do the color conversion from the color space and storage format of given ImageData to the color space and matching pixel format of canvas prior to putting data into the canvas. > > This CL does half the job by adding required methods and the proper unit tests to ImageData. > > BUG=704155, 706850 > > Review-Url: https://codereview.chromium.org/2771813003 > Cr-Commit-Position: refs/heads/master@{#461249} > Committed: https://chromium.googlesource.com/chromium/src/+/8befd9e691b73db52cc1d6edb6a99c1043a15b89 TBR=junov@chromium.org,zakerinasab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=704155, 706850 Review-Url: https://codereview.chromium.org/2798523002 Cr-Commit-Position: refs/heads/master@{#461651} Committed: https://chromium.googlesource.com/chromium/src/+/634dbb84b4876a928019a96d8cc80a011223f854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -805 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.h View 7 chunks +20 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.cpp View 15 chunks +102 lines, -408 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageDataTest.cpp View 2 chunks +2 lines, -335 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Timothy Loh
Created Revert of Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData
3 years, 8 months ago (2017-04-04 05:10:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798523002/1
3 years, 8 months ago (2017-04-04 05:10:42 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/183144) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-04 05:12:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798523002/1
3 years, 8 months ago (2017-04-04 05:19:38 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 07:10:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/634dbb84b4876a928019a96d8cc8...

Powered by Google App Engine
This is Rietveld 408576698