DescriptionRevert of Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData (patchset #10 id:180001 of https://codereview.chromium.org/2771813003/ )
Reason for revert:
TestConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat crashing
On WebKit Linux Trusty (dbg), has been flakily crashing (passing on retry) since it was added but now is crashing consistently.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29
Crashes more on the ClangToTLinuxASan/ClangToTMacASan fyi bots.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=TestConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat
Original issue's description:
> Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData
>
> * createImageData() and getImageData() must return an ImageData for which the color space and storage format matches those of canvas.
> If canvas pixel format is "float16", the storage format of the returned ImageData must be "float32". Values must be properly converted from float16 to float32.
>
> * putImageData must do the color conversion from the color space and storage format of given ImageData to the color space and matching pixel format of canvas prior to putting data into the canvas.
>
> This CL does half the job by adding required methods and the proper unit tests to ImageData.
>
> BUG=704155, 706850
>
> Review-Url: https://codereview.chromium.org/2771813003
> Cr-Commit-Position: refs/heads/master@{#461249}
> Committed: https://chromium.googlesource.com/chromium/src/+/8befd9e691b73db52cc1d6edb6a99c1043a15b89
TBR=junov@chromium.org,zakerinasab@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=704155, 706850
Review-Url: https://codereview.chromium.org/2798523002
Cr-Commit-Position: refs/heads/master@{#461651}
Committed: https://chromium.googlesource.com/chromium/src/+/634dbb84b4876a928019a96d8cc80a011223f854
Patch Set 1 #
Messages
Total messages: 10 (5 generated)
|