Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2798453002: [instrumentation]: Move probe subscriptions to JSON5 config file from PIDL. (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[instrumentation]: Move probe subscriptions to JSON5 config file from PIDL. BUG=695625 Review-Url: https://codereview.chromium.org/2798453002 Cr-Commit-Position: refs/heads/master@{#462012} Committed: https://chromium.googlesource.com/chromium/src/+/68e4a897f7551cf7c603cb9ad1fbf534da856c91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -401 lines) Patch
M third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py View 5 chunks +42 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.json5 View 1 chunk +170 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.pidl View 2 chunks +156 lines, -348 lines 0 comments Download
M third_party/WebKit/Source/platform/probe/PlatformProbes.json5 View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/probe/PlatformProbes.pidl View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
alph
3 years, 8 months ago (2017-04-03 23:41:55 UTC) #2
pfeldman
lgtm
3 years, 8 months ago (2017-04-04 20:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798453002/1
3 years, 8 months ago (2017-04-05 07:10:37 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 08:53:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68e4a897f7551cf7c603cb9ad1fb...

Powered by Google App Engine
This is Rietveld 408576698