[SAB] Fix {newtarget-prototype-is-not-object,proto-from-ctor-realm} tests

[SAB] Fix {newtarget-prototype-is-not-object,proto-from-ctor-realm} tests

This revealed a bug in the TypedArray(typedArray) constructor when the arg is backed by a SharedArrayBuffer.

Also install the species getter and add a test, since it's not tested in
test262 presently.

BUG=v8:5983, v8:5984
R=adamk@chromium.org

Review-Url: https://codereview.chromium.org/2798403004
Cr-Commit-Position: refs/heads/master@{#44500}
Committed: https://chromium.googlesource.com/v8/v8/+/03e260cb2acaddb119676182194052215b213b0b

[binji, 2017-04-07 00:28:03]

Description was changed from

==========
[SAB] Fix {newtarget-prototype-is-not-object,proto-from-ctor-realm} tests

BUG=v8:5983,v8:5984
R=adamk@chromium.org
==========

to

==========
[SAB] Fix {newtarget-prototype-is-not-object,proto-from-ctor-realm} tests

Also install the species getter and add a test, since it's not tested in
test262 presently.

BUG=v8:5983,v8:5984
R=adamk@chromium.org
==========

[adamk, 2017-04-07 00:31:02]

lgtm

[binji, 2017-04-07 00:31:43]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2017-04-07 00:31:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 00:52:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 00:52:19]

Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/23969)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[binji, 2017-04-07 02:58:02]

binji@chromium.org changed reviewers:
+ littledan@chromium.org

[binji, 2017-04-07 02:59:04]

Description was changed from

==========
[SAB] Fix {newtarget-prototype-is-not-object,proto-from-ctor-realm} tests

Also install the species getter and add a test, since it's not tested in
test262 presently.

BUG=v8:5983,v8:5984
R=adamk@chromium.org
==========

to

==========
[SAB] Fix {newtarget-prototype-is-not-object,proto-from-ctor-realm} tests

This revealed a bug in the TypedArray(typedArray) constructor when the arg is
backed by a SharedArrayBuffer.

Also install the species getter and add a test, since it's not tested in
test262 presently.

BUG=v8:5983,v8:5984
R=adamk@chromium.org
==========

[binji, 2017-04-07 03:00:10]

+littledan

FYI: this fix exposed an issue with the TypedArray(typedArray) constructor.
PTAL for correctness of fix.

[binji, 2017-04-07 03:00:20]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 03:00:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 03:24:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 03:24:20]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2017-04-07 15:22:31]

lgtm for correctness.

For testing:
- Is there a test for the new TypedArray(typedArray) behavior directly? Among
the tests I can see that are added/turned on, it looks like they come from
adding species, but maybe I'm misunderstanding.
- It'd be awesome if the test you're adding could be a test262 test. You can
develop test262 tests locally within a V8 patch by putting them in
test/test262/local-tests. However, I understand if this is too much overhead.

It took me a bit to understand the motivation; it's explained in this bug thread
if anyone else is interested:
https://github.com/tc39/ecmascript_sharedmem/issues/149

[adamk, 2017-04-07 17:24:21]

lgtm

To Dan's coverage question, the new behavior in patch set 2 is covered by
test262/built-ins/TypedArrays/buffer-arg-typedarray-backed-by-sharedarraybuffer

https://codereview.chromium.org/2798403004/diff/20001/src/js/typedarray.js
File src/js/typedarray.js (right):

https://codereview.chromium.org/2798403004/diff/20001/src/js/typedarray.js#ne...
src/js/typedarray.js:150: var bufferConstructor =
(IS_SHAREDARRAYBUFFER(srcData))
Nit: no need for the extra parens (the macros already have parens to avoid
problems).

Also, can you add a comment here with a short explanation of why this check
needs to be here? It looks pretty without any context.

[binji, 2017-04-07 18:55:36]

https://codereview.chromium.org/2798403004/diff/20001/src/js/typedarray.js
File src/js/typedarray.js (right):

https://codereview.chromium.org/2798403004/diff/20001/src/js/typedarray.js#ne...
src/js/typedarray.js:150: var bufferConstructor =
(IS_SHAREDARRAYBUFFER(srcData))
On 2017/04/07 17:24:21, adamk wrote:
> Nit: no need for the extra parens (the macros already have parens to avoid
> problems).
> 
> Also, can you add a comment here with a short explanation of why this check
> needs to be here? It looks pretty without any context.

Done.

[binji, 2017-04-07 18:55:42]

The CQ bit was checked by binji@chromium.org

[binji, 2017-04-07 18:55:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org, adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2798403004/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-04-07 18:55:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:21:38]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[binji, 2017-04-08 19:23:09]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 19:23:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 19:58:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 19:58:47]

Dry run: This issue passed the CQ dry run.

[binji, 2017-04-08 20:12:00]

The CQ bit was checked by binji@chromium.org

[binji, 2017-04-08 20:12:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org, adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2798403004/#ps60001
(title: "skip test that fails because of ASAN allocation failure")

[commit-bot: I haz the power, 2017-04-08 20:12:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 20:13:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491682320905870,
"parent_rev": "4faa4952fdd49eb2e75d2eac54dc17043793cb1d", "commit_rev":
"03e260cb2acaddb119676182194052215b213b0b"}

[commit-bot: I haz the power, 2017-04-08 20:13:53]

Description was changed from

==========
[SAB] Fix {newtarget-prototype-is-not-object,proto-from-ctor-realm} tests

This revealed a bug in the TypedArray(typedArray) constructor when the arg is
backed by a SharedArrayBuffer.

Also install the species getter and add a test, since it's not tested in
test262 presently.

BUG=v8:5983,v8:5984
R=adamk@chromium.org
==========

to

==========
[SAB] Fix {newtarget-prototype-is-not-object,proto-from-ctor-realm} tests

This revealed a bug in the TypedArray(typedArray) constructor when the arg is
backed by a SharedArrayBuffer.

Also install the species getter and add a test, since it's not tested in
test262 presently.

BUG=v8:5983,v8:5984
R=adamk@chromium.org

Review-Url: https://codereview.chromium.org/2798403004
Cr-Commit-Position: refs/heads/master@{#44500}
Committed:
https://chromium.googlesource.com/v8/v8/+/03e260cb2acaddb119676182194052215b2...
==========

[commit-bot: I haz the power, 2017-04-08 20:13:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/03e260cb2acaddb119676182194052215b2...