Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2798393002: Work around unicode issues by re-encoding properties as utf-8 (Closed)

Created:
3 years, 8 months ago by Paweł Hajdan Jr.
Modified:
3 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M recipe_engine/util.py View 1 1 chunk +16 lines, -0 lines 0 comments Download
M recipe_modules/json/api.py View 1 1 chunk +1 line, -15 lines 0 comments Download
M recipes.py View 1 2 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
iannucci
https://codereview.chromium.org/2798393002/diff/1/recipes.py File recipes.py (right): https://codereview.chromium.org/2798393002/diff/1/recipes.py#newcode185 recipes.py:185: def strip_unicode(obj): Could we move this function to e.g. ...
3 years, 8 months ago (2017-04-06 18:10:12 UTC) #4
Paweł Hajdan Jr.
Done. PTAL.
3 years, 8 months ago (2017-04-06 18:14:03 UTC) #7
iannucci
lgtm thanks https://codereview.chromium.org/2798393002/diff/20001/recipes.py File recipes.py (right): https://codereview.chromium.org/2798393002/diff/20001/recipes.py#newcode21 recipes.py:21: reload(sys) Comment: # This is necessary to ...
3 years, 8 months ago (2017-04-06 18:16:00 UTC) #10
Paweł Hajdan Jr.
https://codereview.chromium.org/2798393002/diff/20001/recipes.py File recipes.py (right): https://codereview.chromium.org/2798393002/diff/20001/recipes.py#newcode21 recipes.py:21: reload(sys) On 2017/04/06 18:15:59, iannucci wrote: > Comment: > ...
3 years, 8 months ago (2017-04-06 18:18:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798393002/40001
3 years, 8 months ago (2017-04-10 06:34:43 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 06:37:41 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/86179ebcb99567b956e788bb1a100c262f5...

Powered by Google App Engine
This is Rietveld 408576698