Work around unicode issues by re-encoding properties as utf-8

Work around unicode issues by re-encoding properties as utf-8

BUG=chromium:709103
Review-Url: https://codereview.chromium.org/2798393002
Committed: https://github.com/luci/recipes-py/commit/86179ebcb99567b956e788bb1a100c262f533083

[Paweł Hajdan Jr., 2017-04-06 18:09:02]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 18:09:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-04-06 18:10:11]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2017-04-06 18:10:12]

https://codereview.chromium.org/2798393002/diff/1/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2798393002/diff/1/recipes.py#newcode185
recipes.py:185: def strip_unicode(obj):
Could we move this function to e.g. util.py and then import+use it from the json
recipe module, so that it's not defined in two places? Then if we have to fix a
bug in it, we don't get diverging behaviors.

https://codereview.chromium.org/2798393002/diff/1/recipes.py#newcode252
recipes.py:252: reload(sys)
Now that I think about this, I would actually do this even earlier, maybe at
line 20 in this file? This needs to apply in all modes of recipe engine
execution, not just run.

[commit-bot: I haz the power, 2017-04-06 18:12:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:12:26]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2017-04-06 18:14:03]

Done. PTAL.

[Paweł Hajdan Jr., 2017-04-06 18:14:10]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 18:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-04-06 18:16:00]

lgtm thanks

https://codereview.chromium.org/2798393002/diff/20001/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2798393002/diff/20001/recipes.py#newcode21
recipes.py:21: reload(sys)
Comment:

# This is necessary to ensure that str literals are by-default assumed to hold
utf-8. It also makes the
# implicit str(unicode(...)) act like unicode(...).encode('utf-8'), rather than
unicode(...).encode('ascii')

[commit-bot: I haz the power, 2017-04-06 18:17:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:17:05]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2017-04-06 18:18:27]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 18:18:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2017-04-06 18:18:41]

https://codereview.chromium.org/2798393002/diff/20001/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2798393002/diff/20001/recipes.py#newcode21
recipes.py:21: reload(sys)
On 2017/04/06 18:15:59, iannucci wrote:
> Comment:
> 
> # This is necessary to ensure that str literals are by-default assumed to hold
> utf-8. It also makes the
> # implicit str(unicode(...)) act like unicode(...).encode('utf-8'), rather
than
> unicode(...).encode('ascii')

Done.

[commit-bot: I haz the power, 2017-04-06 18:22:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:22:05]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2017-04-10 06:34:33]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2017-04-10 06:34:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2798393002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2017-04-10 06:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 06:37:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491806073788640,
"parent_rev": "2ea2b19c4deb2f81b462754509e2c858e73078ec", "commit_rev":
"86179ebcb99567b956e788bb1a100c262f533083"}

[commit-bot: I haz the power, 2017-04-10 06:37:40]

Description was changed from

==========
Work around unicode issues by re-encoding properties as utf-8

BUG=chromium:709103
==========

to

==========
Work around unicode issues by re-encoding properties as utf-8

BUG=chromium:709103

Review-Url: https://codereview.chromium.org/2798393002
Committed:
https://github.com/luci/recipes-py/commit/86179ebcb99567b956e788bb1a100c262f5...
==========

[commit-bot: I haz the power, 2017-04-10 06:37:41]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/86179ebcb99567b956e788bb1a100c262f5...