Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2798363003: Revert "gpu: Use mojom API for creating gpu channel." (Closed)

Created:
3 years, 8 months ago by hywu
Modified:
3 years, 8 months ago
Reviewers:
henryhsu, sadrul, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert "gpu: Use mojom API for creating gpu channel." This reverts commit 550e264fded00563fd094dfdf527b5073924432b. The commit changes the creating gpu channel IPC to go over mojo while initialization still over Chrome IPC, and thus the IPCs may be out of order. This results in flaky video_ChromeRTCHWDecodeUsed test. BUG=697660 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2798363003 Cr-Commit-Position: refs/branch-heads/3029@{#713} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/d93c1602a934af474125c49432617d4768cb45c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -32 lines) Patch
M content/browser/gpu/gpu_process_host.h View 4 chunks +10 lines, -7 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 6 chunks +42 lines, -24 lines 0 comments Download
M content/common/gpu_host_messages.h View 3 chunks +21 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_service.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
sadrul
lgtm
3 years, 8 months ago (2017-04-14 12:53:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798363003/1
3 years, 8 months ago (2017-04-14 13:26:45 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-14 13:26:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798363003/1
3 years, 8 months ago (2017-04-14 13:31:31 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 13:36:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d93c1602a934af474125c4943261...

Powered by Google App Engine
This is Rietveld 408576698