Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2798363002: [subresource_filter] Include WebSocket bit to the default element_types. (Closed)

Created:
3 years, 8 months ago by pkalinnikov
Modified:
3 years, 8 months ago
CC:
chromium-reviews, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Include WebSocket bit to the default element_types. This change makes a difference of about 64 kB in the memory footprint of IndexedRuleset. BUG=708458 Review-Url: https://codereview.chromium.org/2798363002 Cr-Commit-Position: refs/heads/master@{#462833} Committed: https://chromium.googlesource.com/chromium/src/+/f529b3a0319b740dcef179629b6fd949d7417cbd

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/subresource_filter/core/common/flat/rules.fbs View 1 chunk +2 lines, -1 line 0 comments Download
M components/subresource_filter/core/common/indexed_ruleset.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
pkalinnikov
PTAL.
3 years, 8 months ago (2017-04-06 17:05:12 UTC) #3
engedy
LGTM, nice catch!
3 years, 8 months ago (2017-04-07 07:59:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798363002/20001
3 years, 8 months ago (2017-04-07 10:15:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f529b3a0319b740dcef179629b6fd949d7417cbd
3 years, 8 months ago (2017-04-07 11:03:29 UTC) #14
Charlie Harrison
3 years, 8 months ago (2017-04-07 12:10:30 UTC) #15
Message was sent while issue was closed.
lgtm/2

Powered by Google App Engine
This is Rietveld 408576698