Un-skipped wpt frame-ancestors tests

Un-skipped wpt frame-ancestors tests

Moved over local tests that are more comprehensive than the ones present
Adapted the moved-over local tests to use testharness
Removed old tests because they covered the same things in less detail
Un-skipped the folder in TestExpectations

BUG=694525
Review-Url: https://codereview.chromium.org/2798353002
Cr-Commit-Position: refs/heads/master@{#462834}
Committed: https://chromium.googlesource.com/chromium/src/+/2bc59bf7aa1a5d85fbb23d3481fa46501d45c5f3

[andypaicu, 2017-04-06 15:37:37]

andypaicu@chromium.org changed reviewers:
+ mkwst@chromium.org

[andypaicu, 2017-04-06 15:37:41]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 15:38:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 16:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:37:14]

Dry run: This issue passed the CQ dry run.

[Mike West, 2017-04-07 08:55:33]

LGTM.

I spot-checked the additions, but didn't look at the deletions at all. I trust
you're doing the right thing. :)

[Mike West, 2017-04-07 08:55:44]

(Sorry about all the perl!)

[andypaicu, 2017-04-07 09:03:29]

On 2017/04/07 at 08:55:33, mkwst wrote:
> LGTM.
> 
> I spot-checked the additions, but didn't look at the deletions at all. I trust
you're doing the right thing. :)

Red eagle to command, red eagle to command. I have finally acquired their trust.

Basically moved all of our local tests over. The existing tests were doing the
same thing of nested iframe test just less use cases.

[andypaicu, 2017-04-07 09:05:56]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 09:06:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 09:12:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 09:12:21]

Dry run: This issue passed the CQ dry run.

[andypaicu, 2017-04-07 09:33:04]

The CQ bit was checked by andypaicu@chromium.org

[commit-bot: I haz the power, 2017-04-07 09:33:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 09:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 09:39:49]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1804
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with
conflicts.
  U third_party/WebKit/LayoutTests/TestExpectations

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
1408ebf3d64ee7adb543366d39e5f00f0e90a063..a2a550c68427a21c2d8d8591e1108bb1f1ec0ced
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1804,6 +1804,7 @@ crbug.com/698077
inspector/sources/debugger/debug-inlined-scripts.html [ NeedsMa
 crbug.com/694525 external/wpt/content-security-policy [ Skip ]
 crbug.com/694525 external/wpt/content-security-policy/connect-src [ Pass ]
 crbug.com/694525 external/wpt/content-security-policy/font-src [ Pass ]
+crbug.com/694525 external/wpt/content-security-policy/frame-ancestors [ Pass ]
 crbug.com/694525 external/wpt/content-security-policy/img-src [ Pass ]
 crbug.com/694525 external/wpt/content-security-policy/inside-worker [ Pass ]
 crbug.com/694525 external/wpt/content-security-policy/media-src [ Pass ]

[andypaicu, 2017-04-07 10:09:49]

The CQ bit was checked by andypaicu@chromium.org

[andypaicu, 2017-04-07 10:09:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2798353002/#ps20001
(title: "Rebase-update")

[commit-bot: I haz the power, 2017-04-07 10:10:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 11:09:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491559789233320,
"parent_rev": "f529b3a0319b740dcef179629b6fd949d7417cbd", "commit_rev":
"2bc59bf7aa1a5d85fbb23d3481fa46501d45c5f3"}

[commit-bot: I haz the power, 2017-04-07 11:10:16]

Description was changed from

==========
Un-skipped wpt frame-ancestors tests

Moved over local tests that are more comprehensive than the ones present
Adapted the moved-over local tests to use testharness
Removed old tests because they covered the same things in less detail
Un-skipped the folder in TestExpectations

BUG=694525
==========

to

==========
Un-skipped wpt frame-ancestors tests

Moved over local tests that are more comprehensive than the ones present
Adapted the moved-over local tests to use testharness
Removed old tests because they covered the same things in less detail
Un-skipped the folder in TestExpectations

BUG=694525

Review-Url: https://codereview.chromium.org/2798353002
Cr-Commit-Position: refs/heads/master@{#462834}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bc59bf7aa1a5d85fbb23d3481fa...
==========

[commit-bot: I haz the power, 2017-04-07 11:10:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2bc59bf7aa1a5d85fbb23d3481fa...

[qyearsley, 2017-04-07 15:50:53]

Note, a PR in web-platform-tests was made for this
(https://github.com/w3c/web-platform-tests/pull/5422) but it wasn't merged
because it didn't pass the lint checks :-( Specifically, apparently
"console.log" is not allowed in wpt tests.

jeffcarp@, in this kind of case, what's the best way to get passed this for now?
 - Manually make/modify a PR that makes this change but also fixes the lint
check?
 - Revert and recommit in Chromium with fixes?
 - Make a PR adding a lint exception upstream and then retry the Travis checks?

Meanwhile, the underlying issue here is that we're not running the upstream lint
checks before committing in Chromium (http://crbug.com/686927).

[jeffcarp, 2017-04-07 16:11:38]

On 2017/04/07 at 15:50:53, qyearsley wrote:
> Note, a PR in web-platform-tests was made for this
(https://github.com/w3c/web-platform-tests/pull/5422) but it wasn't merged
because it didn't pass the lint checks :-( Specifically, apparently
"console.log" is not allowed in wpt tests.
> 
> jeffcarp@, in this kind of case, what's the best way to get passed this for
now?
>  - Manually make/modify a PR that makes this change but also fixes the lint
check?
>  - Revert and recommit in Chromium with fixes?
>  - Make a PR adding a lint exception upstream and then retry the Travis
checks?
> 
> Meanwhile, the underlying issue here is that we're not running the upstream
lint checks before committing in Chromium (http://crbug.com/686927).

For lint errors I usually pull the branch down locally and fix them. I'll try
that with this one.

[jeffcarp, 2017-04-07 18:26:15]

On 2017/04/07 at 16:11:38, jeffcarp wrote:
> On 2017/04/07 at 15:50:53, qyearsley wrote:
> > Note, a PR in web-platform-tests was made for this
(https://github.com/w3c/web-platform-tests/pull/5422) but it wasn't merged
because it didn't pass the lint checks :-( Specifically, apparently
"console.log" is not allowed in wpt tests.
> > 
> > jeffcarp@, in this kind of case, what's the best way to get passed this for
now?
> >  - Manually make/modify a PR that makes this change but also fixes the lint
check?
> >  - Revert and recommit in Chromium with fixes?
> >  - Make a PR adding a lint exception upstream and then retry the Travis
checks?
> > 
> > Meanwhile, the underlying issue here is that we're not running the upstream
lint checks before committing in Chromium (http://crbug.com/686927).
> 
> For lint errors I usually pull the branch down locally and fix them. I'll try
that with this one.

Good news everyone, the PR went through:
https://github.com/w3c/web-platform-tests/pull/5422

I had to remove all the console.logs, so for logs that were redundant with
assertion messages I deleted them, and for ones that weren't I turned them into
comments.