Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 2798343002: Remove updates enabled check for webapks. (Closed)

Created:
3 years, 8 months ago by Yaron
Modified:
3 years, 8 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org, Xi Han
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove updates enabled check for webapks. It's impossible under any normal flow to have a WebAPK but updates disabled now. BUG=708274 Review-Url: https://codereview.chromium.org/2798343002 Cr-Commit-Position: refs/heads/master@{#462610} Committed: https://chromium.googlesource.com/chromium/src/+/46a8dce41297331415c5d0ecbfe05acd181d1e80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Yaron
3 years, 8 months ago (2017-04-06 15:35:26 UTC) #4
pkotwicz
LGTM
3 years, 8 months ago (2017-04-06 17:38:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798343002/1
3 years, 8 months ago (2017-04-06 19:53:56 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 20:48:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46a8dce41297331415c5d0ecbfe0...

Powered by Google App Engine
This is Rietveld 408576698