Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2798333005: Moves WmWindow::GetInternalWidget() into a standalone function (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves WmWindow::GetInternalWidget() into a standalone function BUG=687656 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2798333005 Cr-Commit-Position: refs/heads/master@{#463084} Committed: https://chromium.googlesource.com/chromium/src/+/10784779e17f9d143d5f57c7ff902ee7efc0cc81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -28 lines) Patch
M ash/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/accelerators/debug_commands.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/devtools/ash_devtools_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M ash/common/focus_cycler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/wm_window.h View 3 chunks +2 lines, -7 lines 0 comments Download
M ash/common/wm_window.cc View 3 chunks +4 lines, -9 lines 0 comments Download
A ash/wm/widget_finder.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ash/wm/widget_finder.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M ash/wm/window_mirror_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 8 months ago (2017-04-07 23:27:24 UTC) #1
James Cook
LGTM
3 years, 8 months ago (2017-04-07 23:30:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798333005/1
3 years, 8 months ago (2017-04-07 23:31:39 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 00:56:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10784779e17f9d143d5f57c7ff90...

Powered by Google App Engine
This is Rietveld 408576698