Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2798333002: [heap] Fix page promotions tests (Closed)

Created:
3 years, 8 months ago by Michael Lippautz
Modified:
3 years, 8 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix page promotions tests Drive-by: Fix some getters. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2798333002 Cr-Commit-Position: refs/heads/master@{#44449} Committed: https://chromium.googlesource.com/v8/v8/+/2db171c2ba138443b2e177f8d31e9d2ba58c3c65

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M src/heap/mark-compact.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/page-parallel-job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/heap/test-page-promotion.cc View 1 4 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Lippautz
ptal
3 years, 8 months ago (2017-04-06 14:27:02 UTC) #2
ulan
lgtm https://codereview.chromium.org/2798333002/diff/1/test/cctest/heap/test-page-promotion.cc File test/cctest/heap/test-page-promotion.cc (right): https://codereview.chromium.org/2798333002/diff/1/test/cctest/heap/test-page-promotion.cc#newcode60 test/cctest/heap/test-page-promotion.cc:60: // Last object in handles should definitely on ...
3 years, 8 months ago (2017-04-06 14:28:22 UTC) #3
Michael Lippautz
https://codereview.chromium.org/2798333002/diff/1/test/cctest/heap/test-page-promotion.cc File test/cctest/heap/test-page-promotion.cc (right): https://codereview.chromium.org/2798333002/diff/1/test/cctest/heap/test-page-promotion.cc#newcode60 test/cctest/heap/test-page-promotion.cc:60: // Last object in handles should definitely on a ...
3 years, 8 months ago (2017-04-06 14:29:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798333002/20001
3 years, 8 months ago (2017-04-06 14:29:41 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 15:20:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2db171c2ba138443b2e177f8d31e9d2ba58...

Powered by Google App Engine
This is Rietveld 408576698