Issue 279833002: Fix compile error if both inline and reference enums are used in a type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279833002: Fix compile error if both inline and reference enums are used in a type. (Closed)

Created:
6 years, 7 months ago by wjywbs

Modified:
6 years, 7 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix compile error if both inline and reference enums are used in a type. The ToString() overloading function of inline and reference enums will conflict because they exist in both global namespace and local classes. This patch chooses the correct ToString() function in different namespaces. R=kalman@chromium.org BUG=371042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269969

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -13 lines)			Patch
	M	tools/json_schema_compiler/cc_generator.py	View		3 chunks	+6 lines, -11 lines	0 comments	Download
	M	tools/json_schema_compiler/h_generator.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

wjywbs

I put the detail in the bug. I'm wondering if I should revert the previous ...

6 years, 7 months ago (2014-05-09 13:35:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjywbs@gmail.com/279833002/1

6 years, 7 months ago (2014-05-12 21:57:22 UTC) #4

Message was sent while issue was closed.

Change committed as 269969

Expand Messages | Collapse Messages