tools/json_schema_compiler/h_generator.py - Issue 279833002: Fix compile error if both inline and reference enums are used in a type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/h_generator.py

Issue 279833002: Fix compile error if both inline and reference enums are used in a type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/h_generator.py

diff --git a/tools/json_schema_compiler/h_generator.py b/tools/json_schema_compiler/h_generator.py

index a7cac43a2b3f08e7fffc3910908b5693af2f4bd4..fbb79e3f817b389340c1397fbf078478657a8653 100644

--- a/tools/json_schema_compiler/h_generator.py

+++ b/tools/json_schema_compiler/h_generator.py

@@ -214,8 +214,6 @@ class _Generator(object):

# static. On the other hand, those declared inline (e.g. in an object) do.

maybe_static = '' if is_toplevel else 'static '

(c.Append()

- .Append('%sstd::string %sToString(%s as_enum);' %

- (maybe_static, classname, classname))

.Append('%sstd::string ToString(%s as_enum);' %

(maybe_static, classname))

.Append('%s%s Parse%s(const std::string& as_string);' %

« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »