Issue 27983004: GM: remove deprecated --ignoreTests flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27983004: GM: remove deprecated --ignoreTests flag (Closed)

Created:
7 years, 2 months ago by epoger

Modified:
7 years, 2 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

GM: remove deprecated --ignoreTests flag BUG=skia:1730 R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=11887

Patch Set 2 : comment #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -20 lines)			Patch
M	gm/gmmain.cpp	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/stderr	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/tests/outputs/ignoring-one-test/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/run.sh	View	1	3 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

borenet

LGTM https://codereview.chromium.org/27983004/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.chromium.org/27983004/diff/1/gm/tests/run.sh#newcode186 gm/tests/run.sh:186: echo "8888/selfte" >>$GM_IGNORE_FAILURES_FILE Confused about why this is ...

7 years, 2 months ago (2013-10-21 17:19:41 UTC) #2

epoger

https://codereview.chromium.org/27983004/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.chromium.org/27983004/diff/1/gm/tests/run.sh#newcode186 gm/tests/run.sh:186: echo "8888/selfte" >>$GM_IGNORE_FAILURES_FILE On 2013/10/21 17:19:41, borenet wrote: > ...

7 years, 2 months ago (2013-10-21 17:25:20 UTC) #3

epoger

7 years, 2 months ago (2013-10-21 17:25:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r11887 (presubmit successful).

Expand Messages | Collapse Messages

Issue 27983004: GM: remove deprecated --ignoreTests flag (Closed)

Description

Patch Set 1 #

Patch Set 2 : comment #

Messages