Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: gm/gmmain.cpp

Issue 27983004: GM: remove deprecated --ignoreTests flag (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gm/tests/outputs/compared-against-empty-dir/output-expected/command_line » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gmmain.cpp
===================================================================
--- gm/gmmain.cpp (revision 11884)
+++ gm/gmmain.cpp (working copy)
@@ -1425,9 +1425,6 @@
DEFINE_string(ignoreFailuresFile, "", "Path to file containing a list of tests for which we "
"should ignore failures.\n"
"The file should list one test per line, except for comment lines starting with #");
-DEFINE_string(ignoreTests, "", "Space delimited list of tests for which we should ignore "
- "failures.\n"
- "DEPRECATED in favor of --ignoreFailuresFile; see bug 1730");
DEFINE_string(match, "", "[~][^]substring[$] [...] of test name to run.\n"
"Multiple matches may be separated by spaces.\n"
"~ causes a matching test to always be skipped\n"
@@ -2062,14 +2059,6 @@
static bool parse_flags_ignore_tests(SkTArray<SkString> &ignoreTestSubstrings) {
ignoreTestSubstrings.reset();
- // Parse --ignoreTests
- if (FLAGS_ignoreTests.count() > 0) {
- gm_fprintf(stderr, "you are using deprecated --ignoreTests flag\n");
- for (int i = 0; i < FLAGS_ignoreTests.count(); i++) {
- ignoreTestSubstrings.push_back(SkString(FLAGS_ignoreTests[i]));
- }
- }
-
// Parse --ignoreFailuresFile
for (int i = 0; i < FLAGS_ignoreFailuresFile.count(); i++) {
SkTArray<SkString> linesFromFile;
« no previous file with comments | « no previous file | gm/tests/outputs/compared-against-empty-dir/output-expected/command_line » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698