Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2798293003: blink_rename_merge_helper: roll clang tool binaries in COMPONENTS (Closed)

Created:
3 years, 8 months ago by dcheng
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
chromium-reviews, danakj, Ɓukasz Anforowicz
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

blink_rename_merge_helper: roll clang tool binaries in COMPONENTS BUG=676588 R=tkent@chromium.org Review-Url: https://codereview.chromium.org/2798293003 . Cr-Commit-Position: refs/heads/master@{#462750} Committed: https://chromium.googlesource.com/chromium/src/+/5987c4f6a7563c248ba4f78a5e8fb1167bac9613

Patch Set 1 #

Patch Set 2 : make it possible to test changes #

Patch Set 3 : . #

Patch Set 4 : Add Darwin too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M tools/blink_rename_merge_helper/COMPONENTS View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M tools/blink_rename_merge_helper/pylib/blink_rename_merge_helper/driver.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/blink_rename_merge_helper/run.py View 1 2 4 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dcheng
Note: this won't be pushed out until the newest COMPONENTS file is uploaded to gs://chromium-blink-rename. ...
3 years, 8 months ago (2017-04-07 02:24:23 UTC) #2
tkent
lgtm
3 years, 8 months ago (2017-04-07 02:54:42 UTC) #3
dcheng
3 years, 8 months ago (2017-04-07 04:47:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
5987c4f6a7563c248ba4f78a5e8fb1167bac9613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698