[turbofan] Allow to reuse OSR code objects.

[turbofan] Allow to reuse OSR code objects.

Remove the restriction that we cannot reuse code objects generated for
OSR from Ignition to TurboFan.

R=jarin@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4764
Review-Url: https://codereview.chromium.org/2798293002
Cr-Commit-Position: refs/heads/master@{#44437}
Committed: https://chromium.googlesource.com/v8/v8/+/076360c0f19611b66ad1d3c5a8f6b6618de577ea

[Benedikt Meurer, 2017-04-06 07:45:03]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 07:45:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2017-04-06 07:57:32]

On 2017/04/06 07:45:02, Benedikt Meurer wrote:


I thought of doing this, but wasn't sure it was save in the "classic"
configuration. Michi, I guess this was guarding against the same function
getting OSRed from Ignition->TF and FCG->Crankshaft, which can no longer happen
after removing --ignition-staging? If so, LGTM.

[commit-bot: I haz the power, 2017-04-06 08:08:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 08:08:23]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-04-06 08:09:42]

LGTM. Thanks!

https://codereview.chromium.org/2798293002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2798293002/diff/1/src/compiler.cc#newcode915
src/compiler.cc:915: if (info->is_osr() && !ignition_osr) return
MaybeHandle<Code>();
Now that --ignition-staging is no more, and the assumption that we never mix OSR
from Ignition and from FullCodegen, we should also be able to remove the bailout
for this corner case. WDYT?

[Benedikt Meurer, 2017-04-06 10:34:55]

https://codereview.chromium.org/2798293002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2798293002/diff/1/src/compiler.cc#newcode915
src/compiler.cc:915: if (info->is_osr() && !ignition_osr) return
MaybeHandle<Code>();
On 2017/04/06 08:09:42, Michael Starzinger wrote:
> Now that --ignition-staging is no more, and the assumption that we never mix
OSR
> from Ignition and from FullCodegen, we should also be able to remove the
bailout
> for this corner case. WDYT?

Done.

[Benedikt Meurer, 2017-04-06 10:34:59]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-04-06 10:34:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2798293002/#ps20001
(title: "Address comment from Michi.")

[commit-bot: I haz the power, 2017-04-06 10:35:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 11:01:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491474899227180,
"parent_rev": "8f54d18ba4ad10770e9537a2803459feccfe79a3", "commit_rev":
"076360c0f19611b66ad1d3c5a8f6b6618de577ea"}

[commit-bot: I haz the power, 2017-04-06 11:01:24]

Description was changed from

==========
[turbofan] Allow to reuse OSR code objects.

Remove the restriction that we cannot reuse code objects generated for
OSR from Ignition to TurboFan.

R=jarin@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4764
==========

to

==========
[turbofan] Allow to reuse OSR code objects.

Remove the restriction that we cannot reuse code objects generated for
OSR from Ignition to TurboFan.

R=jarin@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4764

Review-Url: https://codereview.chromium.org/2798293002
Cr-Commit-Position: refs/heads/master@{#44437}
Committed:
https://chromium.googlesource.com/v8/v8/+/076360c0f19611b66ad1d3c5a8f6b6618de...
==========

[commit-bot: I haz the power, 2017-04-06 11:01:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/076360c0f19611b66ad1d3c5a8f6b6618de...