Avoid duplicate functions/code in core/editing: kInvalidOffset

Avoid duplicate functions/code in core/editing: kInvalidOffset

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

kInvalidOffset is a name used both by PositionIterator and TextIterator.
This renames on of them kInvalidTextOffset to better match its use and
to avoid the name collision.


BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2798283002
Cr-Commit-Position: refs/heads/master@{#462428}
Committed: https://chromium.googlesource.com/chromium/src/+/00a3908827f01ca5cd0bd911a7f12239975bee33

[Daniel Bratell, 2017-04-06 07:46:03]

bratell@opera.com changed reviewers:
+ yosin@chromium.org

[Daniel Bratell, 2017-04-06 07:46:03]

Please take a look.

[Daniel Bratell, 2017-04-06 09:13:57]

Description was changed from

==========
Avoid duplicate functions/code in core/editing: kInvalidOffset

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

kInvalidOffset is a name used both by PositionIterator and TextIterator.
This renames on of them kInvalidTextOffset to better match its use and
to avoid the name collision.
==========

to

==========
Avoid duplicate functions/code in core/editing: kInvalidOffset

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

kInvalidOffset is a name used both by PositionIterator and TextIterator.
This renames on of them kInvalidTextOffset to better match its use and
to avoid the name collision.


BUG=708949
R=yosin@chromium.org
==========

[yosin_UTC9, 2017-04-06 09:56:32]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-04-06 09:56:32]

lgtm

[commit-bot: I haz the power, 2017-04-06 09:56:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 11:34:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491472592088090, "parent_rev":
"0736e37b73d70fc56a93eeac32fff4a56c946c2d", "commit_rev":
"00a3908827f01ca5cd0bd911a7f12239975bee33"}

[commit-bot: I haz the power, 2017-04-06 11:35:39]

Description was changed from

==========
Avoid duplicate functions/code in core/editing: kInvalidOffset

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

kInvalidOffset is a name used both by PositionIterator and TextIterator.
This renames on of them kInvalidTextOffset to better match its use and
to avoid the name collision.


BUG=708949
R=yosin@chromium.org
==========

to

==========
Avoid duplicate functions/code in core/editing: kInvalidOffset

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

kInvalidOffset is a name used both by PositionIterator and TextIterator.
This renames on of them kInvalidTextOffset to better match its use and
to avoid the name collision.


BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2798283002
Cr-Commit-Position: refs/heads/master@{#462428}
Committed:
https://chromium.googlesource.com/chromium/src/+/00a3908827f01ca5cd0bd911a7f1...
==========

[commit-bot: I haz the power, 2017-04-06 11:35:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00a3908827f01ca5cd0bd911a7f1...