Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2798263006: [Chromecast] Fix CastMediaClient::IsSupportedAudioConfig() for (E)AC3 on Android (Closed)

Created:
3 years, 8 months ago by AndyWu
Modified:
3 years, 7 months ago
Reviewers:
servolk, halliwell, Simeon
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix CastMediaClient::IsSupportedAudioConfig() for (E)AC3 on Android Before we have the chance to fully implement the function, we need a quick fix for (E)AC3. No ATV we know of that supports (E)AC3 decoder, so it relies on the audio sink device. BUG=Internal b/36896359 Review-Url: https://codereview.chromium.org/2798263006 Cr-Commit-Position: refs/heads/master@{#463010} Committed: https://chromium.googlesource.com/chromium/src/+/083658601292da9c95167513264e69a776ae97af

Patch Set 1 #

Patch Set 2 : [Chromecast] Fix CastMediaClient::IsSupportedAudioConfig() for (E)AC3 on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chromecast/renderer/cast_content_renderer_client.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
AndyWu
3 years, 8 months ago (2017-04-07 20:16:01 UTC) #3
halliwell
On 2017/04/07 20:16:01, AndyWu wrote: lgtm
3 years, 8 months ago (2017-04-07 20:32:25 UTC) #4
servolk
On 2017/04/07 20:16:01, AndyWu wrote: lgtm
3 years, 8 months ago (2017-04-07 20:40:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798263006/1
3 years, 8 months ago (2017-04-07 21:31:10 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 21:46:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/083658601292da9c95167513264e...

Powered by Google App Engine
This is Rietveld 408576698