Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2798263003: Image Capture: add |supports_torch| field to mojom (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, mcasas+imagecapture_chromium.org, blink-reviews, xjz+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: add |supports_torch| field to mojom This CL adds |supports_torch| to mojom.PhotoCapabilities, to differentiate the capability from the actual value of |torch|, and wires it for the Android implementations and for the LayoutTests. Tested via unittests and manual test using https://rawgit.com/Miguelao/demos/master/imagecapture.html BUG=700607 Review-Url: https://codereview.chromium.org/2798263003 Cr-Commit-Position: refs/heads/master@{#462731} Committed: https://chromium.googlesource.com/chromium/src/+/15f5b51d19bd375b45ca8f9f8377b0522f261395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M media/capture/mojo/image_capture.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java View 7 chunks +16 lines, -3 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 chunk +4 lines, -1 line 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 chunk +5 lines, -2 lines 0 comments Download
M media/capture/video/android/photo_capabilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/android/photo_capabilities.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getSettings.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mcasas
reillyg@ PTAL tsepez@ RS plz the addition to image_capture.mojom
3 years, 8 months ago (2017-04-06 22:47:01 UTC) #5
Reilly Grant (use Gerrit)
LGTM
3 years, 8 months ago (2017-04-06 22:57:30 UTC) #6
Tom Sepez
RS LGTM on adding a single boolean.
3 years, 8 months ago (2017-04-06 23:19:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798263003/20001
3 years, 8 months ago (2017-04-06 23:26:34 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:23:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15f5b51d19bd375b45ca8f9f8377...

Powered by Google App Engine
This is Rietveld 408576698