Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2798243006: Add NetLog for HttpStreamFactoryImpl::Job::DoInitConnection (Closed)

Created:
3 years, 8 months ago by Zhongyi Shi
Modified:
3 years, 8 months ago
Reviewers:
eroman, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, eroman, mmenke, net-reviews_chromium.org, Ryan Hamilton
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NetLog for HttpStreamFactoryImpl::Job::DoInitConnection so that if the connection initialization hangs NetLog will log the behavior. This will help investigate bugs similar to crbug.com/700617 in the future. BUG=702411 Review-Url: https://codereview.chromium.org/2798243006 Cr-Commit-Position: refs/heads/master@{#462594} Committed: https://chromium.googlesource.com/chromium/src/+/069464ff67c5ba19b7a0aff04cd88cb646872d81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/log/net_log_event_type_list.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Zhongyi Shi
3 years, 8 months ago (2017-04-06 17:29:00 UTC) #3
eroman
lgtm
3 years, 8 months ago (2017-04-06 17:49:09 UTC) #5
Zhongyi Shi
Thanks Eric! Moving rch@ to cc line to land.
3 years, 8 months ago (2017-04-06 17:58:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798243006/1
3 years, 8 months ago (2017-04-06 17:59:39 UTC) #9
Ryan Hamilton
lgtm
3 years, 8 months ago (2017-04-06 18:37:48 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:54:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/069464ff67c5ba19b7a0aff04cd8...

Powered by Google App Engine
This is Rietveld 408576698