Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2798223006:
MD Settings: Remove tabindex from container after it is blurred. (Closed)
|
Created:
3 years, 8 months ago by dpapad Modified:
3 years, 8 months ago Reviewers:
Dan Beam CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Remove tabindex from container after it is blurred.
Clicking on non-focusable elements (for example the "Show home button" row) would
transfer the focus to the container accidentally, now that it has a tabindex. Removing
the tabindex from the container as soon as the container is blurred addresses the problem.
BUG=709359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2798223006
Cr-Commit-Position: refs/heads/master@{#463118}
Committed: https://chromium.googlesource.com/chromium/src/+/3a2e5144ab506f18ae56a2bbe4eb23f43ddd5dcd
Patch Set 1 #Patch Set 2 : Better approach #Patch Set 3 : Address case #Patch Set 4 : pointer down #
Total comments: 2
Patch Set 5 : remove event parameter #
Messages
Total messages: 23 (17 generated)
Description was changed from ========== MD Settings: DO NOT SUBMIT, fixing settings-box focus now that the container has tabindex -1. BUG=709359 ========== to ========== MD Settings: DO NOT SUBMIT, fixing settings-box focus now that the container has tabindex -1. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: DO NOT SUBMIT, fixing settings-box focus now that the container has tabindex -1. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove tabindex from container after it is blurred, DO NOT SUBMIT. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MD Settings: Remove tabindex from container after it is blurred, DO NOT SUBMIT. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove tabindex from container after it is blurred, DO NOT SUBMIT. Clicking on non-focusable elements (for example the "Show home button" row) would transfer the focus to the container accidentally, now that it has a tabindex. Removing the tabindex from the container as soon as the container is blurred addresses the problem. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: Remove tabindex from container after it is blurred, DO NOT SUBMIT. Clicking on non-focusable elements (for example the "Show home button" row) would transfer the focus to the container accidentally, now that it has a tabindex. Removing the tabindex from the container as soon as the container is blurred addresses the problem. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove tabindex from container after it is blurred. Clicking on non-focusable elements (for example the "Show home button" row) would transfer the focus to the container accidentally, now that it has a tabindex. Removing the tabindex from the container as soon as the container is blurred addresses the problem. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dpapad@chromium.org changed reviewers: + dbeam@chromium.org
The solution got a bit more involved than I expected. Here are the 3 cases that work well (and previously did not). Let me know if you think there is a simpler solution that addresses all 3 cases below. Case1: 1 Navigate to chrome://md-settings 2 Click "Show home button" text. 3 Press Tab. Expected: The toggle next to "Show home button" text is focused. Case2: 1 Navigate to chrome://md-settings 2 Open and close sidebar. 3 Click "Show home button" text. 4 Press Tab. Expected: The toggle next to "Show home button" text is focused. Case3: 1 Navigate to chrome://md-settings 2 Open and close sidebar. 3 Press down arrow Expected: Contents should scroll.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Uploaded simplified approach, based on discussion with @dbeam. Tested that all 3 cases mentioned before still work.
booyah! lgtm \o/ https://codereview.chromium.org/2798223006/diff/60001/chrome/browser/resource... File chrome/browser/resources/settings/settings_ui/settings_ui.js (right): https://codereview.chromium.org/2798223006/diff/60001/chrome/browser/resource... chrome/browser/resources/settings/settings_ui/settings_ui.js:275: listenOnce(this.$.container, ['blur', 'pointerdown'], function(e) { nit: don't need |e| any more
https://codereview.chromium.org/2798223006/diff/60001/chrome/browser/resource... File chrome/browser/resources/settings/settings_ui/settings_ui.js (right): https://codereview.chromium.org/2798223006/diff/60001/chrome/browser/resource... chrome/browser/resources/settings/settings_ui/settings_ui.js:275: listenOnce(this.$.container, ['blur', 'pointerdown'], function(e) { On 2017/04/08 at 01:34:16, Dan Beam wrote: > nit: don't need |e| any more Done.
The CQ bit was checked by dpapad@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2798223006/#ps70001 (title: "remove event parameter")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 70001, "attempt_start_ts": 1491615360142720,
"parent_rev": "969287a6341cee8881bd38c1a9019e8c80669d73", "commit_rev":
"3a2e5144ab506f18ae56a2bbe4eb23f43ddd5dcd"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Remove tabindex from container after it is blurred. Clicking on non-focusable elements (for example the "Show home button" row) would transfer the focus to the container accidentally, now that it has a tabindex. Removing the tabindex from the container as soon as the container is blurred addresses the problem. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove tabindex from container after it is blurred. Clicking on non-focusable elements (for example the "Show home button" row) would transfer the focus to the container accidentally, now that it has a tabindex. Removing the tabindex from the container as soon as the container is blurred addresses the problem. BUG=709359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2798223006 Cr-Commit-Position: refs/heads/master@{#463118} Committed: https://chromium.googlesource.com/chromium/src/+/3a2e5144ab506f18ae56a2bbe4eb... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as https://chromium.googlesource.com/chromium/src/+/3a2e5144ab506f18ae56a2bbe4eb... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
