Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2798103002: [Extensions] Fix json_schema_api inputs (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Fix json_schema_api inputs uncompiled_bundle_schema_sources weren't being properly taken into account for inputs. Add them. BUG=708704 TEST=Build chrome; touch chrome/common/extensions/api/tts.json, build chrome again. It should rebuild. Review-Url: https://codereview.chromium.org/2798103002 Cr-Commit-Position: refs/heads/master@{#462189} Committed: https://chromium.googlesource.com/chromium/src/+/19329f51423819645c51d444e38b1aa331c3043d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/json_schema_compiler/json_schema_api.gni View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Devlin
3 years, 8 months ago (2017-04-05 18:30:19 UTC) #2
lazyboy
lgtm
3 years, 8 months ago (2017-04-05 18:38:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798103002/1
3 years, 8 months ago (2017-04-05 18:40:01 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 19:54:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/19329f51423819645c51d444e38b...

Powered by Google App Engine
This is Rietveld 408576698