Fix open paths for download ContentId work

Fix open paths for download ContentId work

Add two new ways to open an OfflineItem in the new API path:
- From the snackbar.
- From the notification.

BUG=691805
Review-Url: https://codereview.chromium.org/2798093003
Cr-Commit-Position: refs/heads/master@{#464080}
Committed: https://chromium.googlesource.com/chromium/src/+/a2d733fbc1be5a976181e17de5021c997dcb711e

[David Trainor- moved to gerrit, 2017-04-07 22:09:38]

dtrainor@chromium.org changed reviewers:
+ fgorski@chromium.org, qinmin@chromium.org

[David Trainor- moved to gerrit, 2017-04-07 22:09:39]

ptal thanks!

[fgorski, 2017-04-10 18:17:04]

https://codereview.chromium.org/2798093003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
(right):

https://codereview.chromium.org/2798093003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java:72:
if (download.notificationId != INVALID_NOTIFICATION_ID) {
Removing return; from 56 will cause this code to always be executed (in case of
offline page). Was that intended?

[David Trainor- moved to gerrit, 2017-04-10 18:40:55]

https://codereview.chromium.org/2798093003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
(right):

https://codereview.chromium.org/2798093003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java:72:
if (download.notificationId != INVALID_NOTIFICATION_ID) {
On 2017/04/10 18:17:04, fgorski wrote:
> Removing return; from 56 will cause this code to always be executed (in case
of
> offline page). Was that intended?

Yes I was trying to unify the experience, although I can re-add the return if
you want.  Basically clicking on the snackbar to open the page won't remove the
"download completed" notification without it.  Right now it gets removed *only*
if it's a download and we're not using the android download manager.  I feel
like that's a bug and we should always remove the notification if we open the
downloaded content.

LMK if you feel differently!

[fgorski, 2017-04-10 20:01:31]

Explanation makes sense. Please run it through Tal.
Either way it ends I am happy.

lgtm

[qinmin, 2017-04-11 06:24:05]

lgtm

[David Trainor- moved to gerrit, 2017-04-11 20:53:06]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 20:53:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 21:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:41:18]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-04-12 07:18:45]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 07:19:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 07:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 07:53:38]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-04-12 17:38:34]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-04-12 17:38:35]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2798093003/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2017-04-12 17:39:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:56:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492018714619800,
"parent_rev": "0ecaeb804b4aab2c9aad6953954705499d2ad4a1", "commit_rev":
"a2d733fbc1be5a976181e17de5021c997dcb711e"}

[commit-bot: I haz the power, 2017-04-12 17:57:41]

Description was changed from

==========
Fix open paths for download ContentId work

Add two new ways to open an OfflineItem in the new API path:
- From the snackbar.
- From the notification.

BUG=691805
==========

to

==========
Fix open paths for download ContentId work

Add two new ways to open an OfflineItem in the new API path:
- From the snackbar.
- From the notification.

BUG=691805

Review-Url: https://codereview.chromium.org/2798093003
Cr-Commit-Position: refs/heads/master@{#464080}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2d733fbc1be5a976181e17de502...
==========

[commit-bot: I haz the power, 2017-04-12 17:57:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a2d733fbc1be5a976181e17de502...