Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2798033003: Fix ErrorPageTestCase to not wait for a matcher with grey_nil() (Closed)

Created:
3 years, 8 months ago by baxley
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ErrorPageTestCase to not wait for a matcher with grey_nil() A negative matcher (WaitForWebViewNotContainingText), should be used instead of the positive matcher with grey_nil(). BUG= Review-Url: https://codereview.chromium.org/2798033003 Cr-Commit-Position: refs/heads/master@{#462128} Committed: https://chromium.googlesource.com/chromium/src/+/0f199cb0e21263e0ce09146c4763c0a99be6b190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ios/chrome/browser/ui/error_page_egtest.mm View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
baxley
I plan to remove these altogether, but this came up when trying to remove WebViewContainsText, ...
3 years, 8 months ago (2017-04-05 16:06:46 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 8 months ago (2017-04-05 16:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798033003/1
3 years, 8 months ago (2017-04-05 17:06:52 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 17:19:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f199cb0e21263e0ce09146c4763...

Powered by Google App Engine
This is Rietveld 408576698