Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2798023004: Prefill the billing address name only when adding a new address. (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
Reviewers:
gogerald1
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefill the billing address name only when adding a new address. Before this patch: "Name required" error in billing address dropdown opens the address editor and immediately fills out the name from "Name on card" field, thus confusing the user why the address editor was opened in the first place. The fix: Fill in billing address name from "Name on card" only when adding a new billing address. After this patch: "Name required" error in billing address drop down opens the address editor and focuses the empty "Name" field. BUG=708589 Review-Url: https://codereview.chromium.org/2798023004 Cr-Commit-Position: refs/heads/master@{#462146} Committed: https://chromium.googlesource.com/chromium/src/+/fa74fc69658bd030e2f4ae96da88244d42cd32e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
please use gerrit instead
Ganggui, ptal.
3 years, 8 months ago (2017-04-05 15:40:50 UTC) #2
gogerald1
lgtm,
3 years, 8 months ago (2017-04-05 17:12:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798023004/1
3 years, 8 months ago (2017-04-05 17:13:46 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 18:11:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa74fc69658bd030e2f4ae96da88...

Powered by Google App Engine
This is Rietveld 408576698