Chromium Code Reviews| Index: cc/PRESUBMIT.py |
| diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py |
| index c89768a81b6ce74f8bdb921f934d5b819d27c167..12f354241de129db9d04e58c9dc28b741748c0a8 100644 |
| --- a/cc/PRESUBMIT.py |
| +++ b/cc/PRESUBMIT.py |
| @@ -32,9 +32,6 @@ def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=N |
| # WebKit ASSERT() is not allowed. |
| if re.search(r"\bASSERT\(", contents): |
| assert_files.append(f.LocalPath()) |
| - # WebKit ASSERT_NOT_REACHED() is not allowed. |
| - if re.search(r"ASSERT_NOT_REACHED\(", contents): |
| - notreached_files.append(f.LocalPath()) |
| if assert_files: |
| return [output_api.PresubmitError( |
| @@ -103,7 +100,7 @@ def CheckPassByValue(input_api, |
| local_errors = [] |
| - # Well-defined simple classes containing only <= 4 ints, or <= 2 floats. |
| + # Well-defined simple classes the same size as a primative type. |
|
Fady Samuel
2017/04/05 17:09:14
nit: primitive
kylechar
2017/04/05 17:14:09
Done.
|
| pass_by_value_types = ['base::Time', |
| 'base::TimeTicks', |
| ] |
| @@ -131,7 +128,7 @@ def CheckTodos(input_api, output_api): |
| if errors: |
| return [output_api.PresubmitError( |
| - 'All TODO comments should be of the form TODO(name). ' + |
| + 'All TODO comments should be of the form TODO(name/bug). ' + |
| 'Use TODO instead of FIX' + 'ME', |
| items=errors)] |
| return [] |