Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 2797993004: Configure components/viz/ directory. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 2 days ago by kylechar
Modified:
3 weeks, 2 days ago
Reviewers:
danakj, Fady Samuel
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Configure components/viz/ directory. Add to OWNERS. Add a PRESUBMIT.py that is similar to cc/PRESUBMIT.py. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2797993004 Cr-Commit-Position: refs/heads/master@{#462142} Committed: https://chromium.googlesource.com/chromium/src/+/e68cc4a0cef3f755dcebcb1cad23560a10c34f7f

Patch Set 1 #

Patch Set 2 : Fix presubmit. #

Total comments: 8

Patch Set 3 : Fixes. #

Total comments: 10

Patch Set 4 : More fixes. #

Patch Set 5 : Typo. #

Messages

Total messages: 28 (14 generated)
kylechar
3 weeks, 2 days ago (2017-04-05 16:36:30 UTC) #2
danakj
https://codereview.chromium.org/2797993004/diff/20001/components/viz/OWNERS File components/viz/OWNERS (right): https://codereview.chromium.org/2797993004/diff/20001/components/viz/OWNERS#newcode5 components/viz/OWNERS:5: danakj@chromium.org OOH there's already an owners here. I didn't ...
3 weeks, 2 days ago (2017-04-05 16:38:07 UTC) #4
danakj
LGTM https://codereview.chromium.org/2797993004/diff/20001/components/viz/PRESUBMIT.py File components/viz/PRESUBMIT.py (right): https://codereview.chromium.org/2797993004/diff/20001/components/viz/PRESUBMIT.py#newcode35 components/viz/PRESUBMIT.py:35: # WebKit ASSERT_NOT_REACHED() is not allowed. ASSERT_NOT_REACHED() has ...
3 weeks, 2 days ago (2017-04-05 16:41:30 UTC) #5
kylechar
It looks like rietveld won't pick up similar python files no matter what I set ...
3 weeks, 2 days ago (2017-04-05 16:41:51 UTC) #6
kylechar
https://codereview.chromium.org/2797993004/diff/20001/components/viz/OWNERS File components/viz/OWNERS (right): https://codereview.chromium.org/2797993004/diff/20001/components/viz/OWNERS#newcode5 components/viz/OWNERS:5: danakj@chromium.org On 2017/04/05 16:38:07, danakj wrote: > OOH there's ...
3 weeks, 2 days ago (2017-04-05 16:53:42 UTC) #8
danakj
Thanks! LGTM https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py File cc/PRESUBMIT.py (left): https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py#oldcode28 cc/PRESUBMIT.py:28: notreached_files = [] this goes https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py#oldcode43 cc/PRESUBMIT.py:43: ...
3 weeks, 2 days ago (2017-04-05 16:59:41 UTC) #9
kylechar
https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py File cc/PRESUBMIT.py (left): https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py#oldcode28 cc/PRESUBMIT.py:28: notreached_files = [] On 2017/04/05 16:59:41, danakj wrote: > ...
3 weeks, 2 days ago (2017-04-05 17:08:48 UTC) #10
Fady Samuel
https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py File cc/PRESUBMIT.py (right): https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py#newcode103 cc/PRESUBMIT.py:103: # Well-defined simple classes the same size as a ...
3 weeks, 2 days ago (2017-04-05 17:09:14 UTC) #11
kylechar
https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py File cc/PRESUBMIT.py (right): https://codereview.chromium.org/2797993004/diff/40001/cc/PRESUBMIT.py#newcode103 cc/PRESUBMIT.py:103: # Well-defined simple classes the same size as a ...
3 weeks, 2 days ago (2017-04-05 17:14:10 UTC) #12
Fady Samuel
lgtm
3 weeks, 2 days ago (2017-04-05 17:21:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797993004/80001
3 weeks, 2 days ago (2017-04-05 17:23:19 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/415736) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 weeks, 2 days ago (2017-04-05 17:31:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797993004/80001
3 weeks, 2 days ago (2017-04-05 17:50:16 UTC) #25
commit-bot: I haz the power
3 weeks, 2 days ago (2017-04-05 18:03:41 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e68cc4a0cef3f755dcebcb1cad23...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46