Configure components/viz/ directory.

cc/PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for cc.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
 import re
 import string
 
 CC_SOURCE_FILES=(r'^cc[\\/].*\.(cc|h)$',)
 
 def CheckChangeLintsClean(input_api, output_api):
   source_filter = lambda x: input_api.FilterSourceFile(
     x, white_list=CC_SOURCE_FILES, black_list=None)
 
   return input_api.canned_checks.CheckChangeLintsClean(
       input_api, output_api, source_filter, lint_filters=[], verbose_level=1)
 
 def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=None):
   black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST)
   source_file_filter = lambda x: input_api.FilterSourceFile(x, white_list, black_list)
 
   assert_files = []
   notreached_files = []

[danakj, 2017/04/05 16:59:41]

this goes

[kylechar, 2017/04/05 17:08:47]

Done.

 
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
     # WebKit ASSERT() is not allowed.
     if re.search(r"\bASSERT\(", contents):
       assert_files.append(f.LocalPath())
-    # WebKit ASSERT_NOT_REACHED() is not allowed.
-    if re.search(r"ASSERT_NOT_REACHED\(", contents):
-      notreached_files.append(f.LocalPath())
 
   if assert_files:
     return [output_api.PresubmitError(
       'These files use ASSERT instead of using DCHECK:',
       items=assert_files)]
   if notreached_files:

[danakj, 2017/04/05 16:59:41]

this goes

[kylechar, 2017/04/05 17:08:47]

Done.

     return [output_api.PresubmitError(
       'These files use ASSERT_NOT_REACHED instead of using NOTREACHED:',
       items=notreached_files)]
   return []
 
 def CheckStdAbs(input_api, output_api,
                 white_list=CC_SOURCE_FILES, black_list=None):
   black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST)
   source_file_filter = lambda x: input_api.FilterSourceFile(x,
                                                             white_list,
@@ skipping 42 matching lines @@
                      output_api,
                      white_list=CC_SOURCE_FILES,
                      black_list=None):
   black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST)
   source_file_filter = lambda x: input_api.FilterSourceFile(x,
                                                             white_list,
                                                             black_list)
 
   local_errors = []
 
-  # Well-defined simple classes containing only <= 4 ints, or <= 2 floats.
+  # Well-defined simple classes the same size as a primative type.

[Fady Samuel, 2017/04/05 17:09:14]

nit: primitive

[kylechar, 2017/04/05 17:14:09]

Done.

   pass_by_value_types = ['base::Time',
                          'base::TimeTicks',
                          ]
 
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
     match = re.search(
       r'\bconst +' + '(?P<type>(%s))&' %
         string.join(pass_by_value_types, '|'),
       contents)
     if match:
       local_errors.append(output_api.PresubmitError(
         '%s passes %s by const ref instead of by value.' %
         (f.LocalPath(), match.group('type'))))
   return local_errors
 
 def CheckTodos(input_api, output_api):
   errors = []
 
   source_file_filter = lambda x: x
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
     if ('FIX'+'ME') in contents:
       errors.append(f.LocalPath())
 
   if errors:
     return [output_api.PresubmitError(
-      'All TODO comments should be of the form TODO(name). ' +
+      'All TODO comments should be of the form TODO(name/bug). ' +
       'Use TODO instead of FIX' + 'ME',
       items=errors)]
   return []
 
 def CheckDoubleAngles(input_api, output_api, white_list=CC_SOURCE_FILES,
                       black_list=None):
   errors = []
 
   source_file_filter = lambda x: input_api.FilterSourceFile(x,
                                                             white_list,
@@ skipping 183 matching lines @@
 def PostUploadHook(cl, change, output_api):
   """git cl upload will call this hook after the issue is created/modified.
 
   This hook adds an extra try bot list to the CL description in order to run
   Blink tests in addition to the CQ try bots.
   """
   return output_api.EnsureCQIncludeTrybotsAreAdded(
     cl,
     ['master.tryserver.blink:linux_trusty_blink_rel'],
     'Automatically added Blink trybots to run Blink tests on CQ.')