Chromium Code Reviews| Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py |
| diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py |
| index fc1a1715f6980ef9ae73d7c69508c1744fa096e8..f2e0ae0c5b5457a7e14db0e7cc6ad67f923ed746 100755 |
| --- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py |
| +++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py |
| @@ -50,6 +50,12 @@ NONPROPERTIES = [ |
| # Explicitly inherits a non-inherited property |
| {'name': 'HasExplicitlyInheritedProperties', 'field_template': 'monotonic_flag', |
| 'inherited': False, 'independent': False, 'default_value': False}, |
| + # These are set if we used viewport or rem units when resolving a length. |
| + # TODO(shend): HasViewportUnits should be a monotonic_flag. |
| + {'name': 'HasViewportUnits', 'field_template': 'flag', 'default_value': 'false', |
|
nainar
2017/04/05 16:41:49
why isnt it a monotonic flag for my own understand
shend
2017/04/05 22:32:36
Good question. setHasViewportUnits currently takes
alancutter (OOO until 2018)
2017/04/06 04:18:49
I don't think this "hack" is the reason it's not a
|
| + 'inherited': False, 'independent': False}, |
| + {'name': 'HasRemUnits', 'field_template': 'monotonic_flag', 'default_value': 'false', |
| + 'inherited': False, 'independent': False}, |
| # These properties only have generated storage, and their methods are handwritten in ComputedStyle. |
| # TODO(shend): Remove these fields and delete the 'storage_only' template. |
| {'name': 'EmptyState', 'field_template': 'storage_only', 'size': 1, 'default_value': 'false', |