Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2797933002: [NTP::Downloads] Show file type icons as 36dp. (Closed)

Created:
3 years, 8 months ago by vitaliii
Modified:
3 years, 8 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::Downloads] Show file type icons as 36dp. UI people agreed to move from 32dp to 36dp. Reasons: 1) We have 36dp resources; 2) The ratio is consistent with Downloads UI. BUG=693552 Review-Url: https://codereview.chromium.org/2797933002 Cr-Commit-Position: refs/heads/master@{#462027} Committed: https://chromium.googlesource.com/chromium/src/+/3fccf108a962616588beaad5adfe2e9cece5ba04

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/android/java/res/values/dimens.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 6 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
vitaliii
Hi dgn@, Could you have a look please? The screenshots are in the bug.
3 years, 8 months ago (2017-04-05 06:57:09 UTC) #6
Michael van Ouwerkerk
lgtm
3 years, 8 months ago (2017-04-05 08:49:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797933002/20001
3 years, 8 months ago (2017-04-05 10:22:31 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 10:29:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3fccf108a962616588beaad5adfe...

Powered by Google App Engine
This is Rietveld 408576698