Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2797923009: Increase Request Mobile Site character limit to 25em. (Closed)

Created:
3 years, 8 months ago by liaoyuke
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase Request Mobile Site character limit to 25em. Per localization request, increasing the character limit of Request Mobile Site messageto 25em. BUG= Review-Url: https://codereview.chromium.org/2797923009 Cr-Commit-Position: refs/heads/master@{#462926} Committed: https://chromium.googlesource.com/chromium/src/+/1cdf325a6009c38dce43ea6ac9c866fdd9ef0ffc

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 16 (10 generated)
liaoyuke
PTAL. Thank you very much!
3 years, 8 months ago (2017-04-07 16:46:44 UTC) #3
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2797923009/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2797923009/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode1456 ios/chrome/app/strings/ios_strings.grd:1456: <message name="IDS_IOS_TOOLS_MENU_REQUEST_MOBILE_SITE" desc="The iOS menu item for requesting the ...
3 years, 8 months ago (2017-04-07 16:49:41 UTC) #4
liaoyuke
IDS_IOS_TOOLS_MENU_EDIT_BOOKMARK is 25em, but that's the only one.
3 years, 8 months ago (2017-04-07 16:55:18 UTC) #5
Eugene But (OOO till 7-30)
lgtm
3 years, 8 months ago (2017-04-07 17:00:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797923009/1
3 years, 8 months ago (2017-04-07 18:10:50 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 18:17:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1cdf325a6009c38dce43ea6ac9c8...

Powered by Google App Engine
This is Rietveld 408576698