Rename PageInfoPopupView to PageInfoBubbleView.

Rename PageInfoPopupView to PageInfoBubbleView.

Also renames PageInfoPopupViewBrowserTest to PageInfoBubbleViewBrowserTest.

BUG=708379
Review-Url: https://codereview.chromium.org/2797923003
Cr-Commit-Position: refs/heads/master@{#462977}
Committed: https://chromium.googlesource.com/chromium/src/+/026e9c4a99abfba45671badb3e0ec8fa2f0b672f

[lgarron, 2017-04-05 04:29:18]

Description was changed from

==========
Rename PageInfoPopupView to PageInfoBubbleView.

BUG=708379
==========

to

==========
Rename PageInfoPopupView to PageInfoBubbleView.

Also renames PageInfoPopupViewBrowserTest to PageInfoBubbleViewBrowserTest.

BUG=708379
==========

[lgarron, 2017-04-05 04:29:34]

lgarron@chromium.org changed reviewers:
+ msw@chromium.org

[lgarron, 2017-04-05 04:29:35]

msw@, could you review?

[lgarron, 2017-04-05 04:31:13]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 04:31:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 06:00:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 06:00:15]

Dry run: This issue passed the CQ dry run.

[msw, 2017-04-05 17:05:52]

https://codereview.chromium.org/2797923003/diff/1/chrome/browser/ui/cocoa/pag...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm (right):

https://codereview.chromium.org/2797923003/diff/1/chrome/browser/ui/cocoa/pag...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm:115: // popup
shown, and that the one that is shown is associated with the current
nit: s/popup/bubble/ here (and elsewhere...)

https://codereview.chromium.org/2797923003/diff/1/chrome/browser/ui/views/pag...
File chrome/browser/ui/views/page_info/page_info_popup_view.h (right):

https://codereview.chromium.org/2797923003/diff/1/chrome/browser/ui/views/pag...
chrome/browser/ui/views/page_info/page_info_popup_view.h:5: #ifndef
CHROME_BROWSER_UI_VIEWS_PAGE_INFO_PAGE_INFO_POPUP_VIEW_H_
Will you follow up to rename the files and other popup mentions therein?
(I'd be okay reviewing if you wanted to rename everything in one sweep)

[lgarron, 2017-04-05 19:03:32]

I've renamed all the relevant occurrences of "popup" I could find. :-)

[msw, 2017-04-05 19:27:20]

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm (right):

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm:115: // bubbl
shown, and that the one that is shown is associated with the current
nit: bubble

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm:1152: // Don't
show the popup if it's already being shown. Since this method is
nit: s/popup/bubble/

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm:1153: // called
each time the location icon is clicked, each click toggles the popup
nit: s/popup/bubble/

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/browser_dialogs_views_mac.cc (right):

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/browser_dialogs_views_mac.cc:33: // Note that when the
browser is toolkit-views, IsPopupShowing() is checked
nit: s/popup/bubble/

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/browser_dialogs_views_mac.cc:34: // earlier because the
popup is shown on mouse release (but dismissed on
nit: s/popup/bubble/

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_icon_view.cc (right):

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_icon_view.cc:58:
PageInfoBubbleView::GetShownPopupType() != PageInfoBubbleView::POPUP_NONE;
Please try to fix compile issues before pinging for review. Let me know when
you've fixed remaining popup references and I'll take another full pass.

[lgarron, 2017-04-05 20:21:08]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 20:21:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 20:27:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 20:27:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[lgarron, 2017-04-05 21:16:25]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:17:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 21:40:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:40:07]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lgarron, 2017-04-05 21:59:19]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:59:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 22:07:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 22:07:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lgarron, 2017-04-06 01:43:33]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 01:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 02:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 02:47:46]

Dry run: This issue passed the CQ dry run.

[lgarron, 2017-04-07 00:36:50]

Sorry for the last revisions. :-(

I've triple-checked that chrome/browser/ui{,views/,cocoa/}/page_info no longer
contains "popup" except when referring to an NSPopUpButton.

Could you review again?

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_icon_view.cc (right):

https://codereview.chromium.org/2797923003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_icon_view.cc:58:
PageInfoBubbleView::GetShownPopupType() != PageInfoBubbleView::POPUP_NONE;
On 2017/04/05 at 19:27:20, msw wrote:
> Please try to fix compile issues before pinging for review. Let me know when
you've fixed remaining popup references and I'll take another full pass.

I was so sure I compiled successfully before uploading. :-(

In any case, trybots pass the latest patch.

[msw, 2017-04-07 09:49:59]

lgtm

[lgarron, 2017-04-07 18:41:06]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:41:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-04-07 18:56:21]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-04-07 18:56:22]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2797923003/#ps120001
(title: "Two more words.")

[commit-bot: I haz the power, 2017-04-07 18:56:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:09:35]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491591381997340,
"parent_rev": "fff0252fe21bce6054b9ea4e73a6cf0b6246b288", "commit_rev":
"026e9c4a99abfba45671badb3e0ec8fa2f0b672f"}

[commit-bot: I haz the power, 2017-04-07 20:10:29]

Description was changed from

==========
Rename PageInfoPopupView to PageInfoBubbleView.

Also renames PageInfoPopupViewBrowserTest to PageInfoBubbleViewBrowserTest.

BUG=708379
==========

to

==========
Rename PageInfoPopupView to PageInfoBubbleView.

Also renames PageInfoPopupViewBrowserTest to PageInfoBubbleViewBrowserTest.

BUG=708379

Review-Url: https://codereview.chromium.org/2797923003
Cr-Commit-Position: refs/heads/master@{#462977}
Committed:
https://chromium.googlesource.com/chromium/src/+/026e9c4a99abfba45671badb3e0e...
==========

[commit-bot: I haz the power, 2017-04-07 20:10:30]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/026e9c4a99abfba45671badb3e0e...