Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2797903002: Geolocation Android: split LocationProviderAndroid out of LocationProviderFactory (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
Reviewers:
scheib
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Geolocation Android: split LocationProviderAndroid out of LocationProviderFactory LocationProviderImpl is a private inner subclass of LocationProviderFactory.java; this CL renames it to LocationProviderAndroid.java and extracts it out of the factory class. Such change is needed to support the incoming LocationProviderGMS (or similar) which provides location based on Google Play Services / GMSCore. This CL intends no new code so the current javatests, content_browsertests and browser_tests should cover this. BUG=706014 Review-Url: https://codereview.chromium.org/2797903002 Cr-Commit-Position: refs/heads/master@{#461985} Committed: https://chromium.googlesource.com/chromium/src/+/7b9777d7a227fff0fdde91437960ba5812207f7e

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -166 lines) Patch
M device/geolocation/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
A device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderAndroid.java View 1 chunk +161 lines, -0 lines 0 comments Download
M device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderFactory.java View 2 chunks +15 lines, -165 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
mcasas
scheib@ ptal
3 years, 8 months ago (2017-04-05 02:38:03 UTC) #5
scheib
lgtm FYI, the TEST= line is intended to flag instructions needed for manual testers. https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list-descriptions ...
3 years, 8 months ago (2017-04-05 05:03:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797903002/40001
3 years, 8 months ago (2017-04-05 05:15:59 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 05:21:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7b9777d7a227fff0fdde91437960...

Powered by Google App Engine
This is Rietveld 408576698