Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2797893003: Fix the issue that Quick View doesn't load images. (Closed)

Created:
3 years, 8 months ago by oka
Modified:
3 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the issue that Quick View doesn't load images. The files_safe_media_webview_content.js, which is loaded inside webview, should be whitelisted in accessible_resources. Quick view had happened to be working before 2768863003 was checked in. After the bug fix on webview is submitted, this proper fix is needed for Quick view to work. BUG=706537 TEST=manually tested Quick View opens an image file. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2797893003 Cr-Commit-Position: refs/heads/master@{#461935} Committed: https://chromium.googlesource.com/chromium/src/+/c433f3648b6a43e43318b0ba72717fd42304b76e

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/file_manager/manifest.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
oka
PTAL.
3 years, 8 months ago (2017-04-05 01:25:52 UTC) #4
fukino
lgtm with a nit. https://codereview.chromium.org/2797893003/diff/1/ui/file_manager/file_manager/manifest.json File ui/file_manager/file_manager/manifest.json (right): https://codereview.chromium.org/2797893003/diff/1/ui/file_manager/file_manager/manifest.json#newcode58 ui/file_manager/file_manager/manifest.json:58: "foreground/elements/files_safe_media_webview_content.js" nit: Sort alphabetically.
3 years, 8 months ago (2017-04-05 01:28:15 UTC) #6
oka
On 2017/04/05 01:28:15, fukino wrote: > lgtm with a nit. > > https://codereview.chromium.org/2797893003/diff/1/ui/file_manager/file_manager/manifest.json > File ...
3 years, 8 months ago (2017-04-05 01:29:15 UTC) #7
oka
.
3 years, 8 months ago (2017-04-05 01:29:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797893003/20001
3 years, 8 months ago (2017-04-05 01:30:18 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 01:57:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c433f3648b6a43e43318b0ba7271...

Powered by Google App Engine
This is Rietveld 408576698