Prevent Android webview tests from being broken by data URL deprecation

Prevent Android webview tests from being broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. This CL changes several tests that use data URLs.

BUG=594215
Review-Url: https://codereview.chromium.org/2797893002
Cr-Commit-Position: refs/heads/master@{#462212}
Committed: https://chromium.googlesource.com/chromium/src/+/0aaeb2dcfffd5bc8bdce71eaf645fea6f477b22d

[meacer, 2017-04-05 01:06:38]

meacer@chromium.org changed reviewers:
+ torne@chromium.org

[meacer, 2017-04-05 01:06:38]

torne: Can you PTAL? I had to remove a test as it's not a realistic scenario
anymore (testCalledForDataUrl), but let me know if you think there is a better
approach.

(I also see that you are in the middle of a move so please feel free to suggest
another reviewer :)

[Torne, 2017-04-05 15:28:38]

Looks fine, just one question:

https://codereview.chromium.org/2797893002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
(right):

https://codereview.chromium.org/2797893002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java:278:
loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), DATA_URL);
Not sure I follow this; why does this change in the opposite direction to the
others?

[meacer, 2017-04-05 17:40:36]

https://codereview.chromium.org/2797893002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
(right):

https://codereview.chromium.org/2797893002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java:278:
loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), DATA_URL);
On 2017/04/05 15:28:38, Torne wrote:
> Not sure I follow this; why does this change in the opposite direction to the
> others?

The URL in line 267 is navigated by a click, and the data URL in that navigation
was going to be blocked, so I changed it to about:blank. But this line is a
direct navigation (note there is no clickOnLinkUsingJs() call after here), so we
can use a data URL.

The reason I changed this is to satisfy the comment in line 276, which as I
understand requires the test to navigate from an about:blank URL to a
non-about:blank URL.

[Torne, 2017-04-05 18:07:15]

lgtm

https://codereview.chromium.org/2797893002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
(right):

https://codereview.chromium.org/2797893002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java:278:
loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), DATA_URL);
On 2017/04/05 17:40:36, Mustafa Emre Acer wrote:
> On 2017/04/05 15:28:38, Torne wrote:
> > Not sure I follow this; why does this change in the opposite direction to
the
> > others?
> 
> The URL in line 267 is navigated by a click, and the data URL in that
navigation
> was going to be blocked, so I changed it to about:blank. But this line is a
> direct navigation (note there is no clickOnLinkUsingJs() call after here), so
we
> can use a data URL.
> 
> The reason I changed this is to satisfy the comment in line 276, which as I
> understand requires the test to navigate from an about:blank URL to a
> non-about:blank URL.

Thanks for the explanation; that looks right, we want to navigate to just "any
other URL" at this point.

[meacer, 2017-04-05 18:09:47]

Thanks! Landing.

[meacer, 2017-04-05 18:09:49]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:10:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:14:24]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[meacer, 2017-04-05 20:31:40]

The CQ bit was checked by meacer@chromium.org

[meacer, 2017-04-05 20:31:41]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2797893002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-05 20:32:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 21:08:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491424300810320,
"parent_rev": "8c16f40605e9b9608ed338606c60c564232211ad", "commit_rev":
"0aaeb2dcfffd5bc8bdce71eaf645fea6f477b22d"}

[commit-bot: I haz the power, 2017-04-05 21:09:15]

Description was changed from

==========
Prevent Android webview tests from being broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. This CL changes several tests that use data URLs.

BUG=594215
==========

to

==========
Prevent Android webview tests from being broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. This CL changes several tests that use data URLs.

BUG=594215

Review-Url: https://codereview.chromium.org/2797893002
Cr-Commit-Position: refs/heads/master@{#462212}
Committed:
https://chromium.googlesource.com/chromium/src/+/0aaeb2dcfffd5bc8bdce71eaf645...
==========

[commit-bot: I haz the power, 2017-04-05 21:09:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0aaeb2dcfffd5bc8bdce71eaf645...