[Payments] base::string16 -> std::string in PaymentMethodData

[Payments] base::string16 -> std::string in PaymentMethodData

base::string16 is overkill for this.

BUG=708052
TEST=existing

Review-Url: https://codereview.chromium.org/2797833002
Cr-Commit-Position: refs/heads/master@{#462069}
Committed: https://chromium.googlesource.com/chromium/src/+/4900df7526f2d89561a1ee4a024ca0be78b60169

[Mathieu, 2017-04-04 21:03:53]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 21:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-04-04 21:05:38]

mathp@chromium.org changed reviewers:
+ mahmadi@chromium.org

[Mathieu, 2017-04-04 21:05:39]

Hi Moe, can you PTAL?

[Mathieu, 2017-04-04 21:05:49]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 21:06:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 22:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 22:32:20]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-04-05 13:54:08]

lgtm

https://codereview.chromium.org/2797833002/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request.mm (right):

https://codereview.chromium.org/2797833002/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request.mm:82: if
(base::IsStringASCII(supported_method))
should we have this check in payment_method_data.cc instead?

[Mathieu, 2017-04-05 13:59:18]

Submitting

https://codereview.chromium.org/2797833002/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request.mm (right):

https://codereview.chromium.org/2797833002/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request.mm:82: if
(base::IsStringASCII(supported_method))
On 2017/04/05 13:54:08, moe wrote:
> should we have this check in payment_method_data.cc instead?

Yes sounds like a good idea! Also made the change to supported_networks and
types

[Mathieu, 2017-04-05 13:59:22]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-04-05 13:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mahmadi@chromium.org
Link to the patchset: https://codereview.chromium.org/2797833002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-04-05 13:59:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 14:49:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491400762564600,
"parent_rev": "1397ae312f38f559bea425268f79b3427b00b7da", "commit_rev":
"4900df7526f2d89561a1ee4a024ca0be78b60169"}

[commit-bot: I haz the power, 2017-04-05 14:50:32]

Description was changed from

==========
[Payments] base::string16 -> std::string in PaymentMethodData

base::string16 is overkill for this.

BUG=708052
TEST=existing
==========

to

==========
[Payments] base::string16 -> std::string in PaymentMethodData

base::string16 is overkill for this.

BUG=708052
TEST=existing

Review-Url: https://codereview.chromium.org/2797833002
Cr-Commit-Position: refs/heads/master@{#462069}
Committed:
https://chromium.googlesource.com/chromium/src/+/4900df7526f2d89561a1ee4a024c...
==========

[commit-bot: I haz the power, 2017-04-05 14:50:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4900df7526f2d89561a1ee4a024c...