Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2797803002: Use TaskScheduler::InitParams to initialize TaskScheduler in web_main_loop.mm. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler::InitParams to initialize TaskScheduler in web_main_loop.mm. Initialization with an arbitrary vector of SchedulerWorkerPoolParams is being deprecated. BUG=690706 Review-Url: https://codereview.chromium.org/2797803002 Cr-Commit-Position: refs/heads/master@{#463233} Committed: https://chromium.googlesource.com/chromium/src/+/86a4c7a17941c0b134df9c103af38eef0edde3a2

Patch Set 1 #

Patch Set 2 : fix-build-error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -78 lines) Patch
M ios/chrome/browser/web/chrome_web_client.h View 1 chunk +2 lines, -4 lines 0 comments Download
M ios/chrome/browser/web/chrome_web_client.mm View 1 chunk +3 lines, -11 lines 0 comments Download
M ios/web/app/web_main_loop.mm View 3 chunks +25 lines, -56 lines 0 comments Download
M ios/web/public/web_client.h View 1 2 chunks +4 lines, -7 lines 0 comments Download
M ios/web/public/web_client.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
fdoray
PTAL
3 years, 8 months ago (2017-04-05 13:02:31 UTC) #10
Eugene But (OOO till 7-30)
lgtm
3 years, 8 months ago (2017-04-07 20:41:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797803002/20001
3 years, 8 months ago (2017-04-07 23:36:16 UTC) #13
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-08 00:44:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797803002/20001
3 years, 8 months ago (2017-04-10 12:27:38 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 12:43:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/86a4c7a17941c0b134df9c103af3...

Powered by Google App Engine
This is Rietveld 408576698